diff options
| author | Michael Adam <obnox@samba.org> | 2015-04-15 08:34:13 +0200 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2015-04-17 23:21:27 +0000 |
| commit | 7fb85e3670cb4743436fd2cf0fbbf9c0869728ec (patch) | |
| tree | 8d12e4cdc07b6cd512d533bccb0283895e554434 | |
| parent | d18c68fbe1608a824bf50ffa3315d7acd5054a15 (diff) | |
upcall: fix use-after free (CID 1288760, 1288761)
Coverity IDs:
1288760 - Read from pointer after free
1288761 - Use after free.
Change-Id: Ide9405b9c30a3e27941054a4ae61f585ef09cd8c
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10242
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
| -rw-r--r-- | xlators/features/upcall/src/upcall-internal.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/xlators/features/upcall/src/upcall-internal.c b/xlators/features/upcall/src/upcall-internal.c index 29c387601f9..41548afb930 100644 --- a/xlators/features/upcall/src/upcall-internal.c +++ b/xlators/features/upcall/src/upcall-internal.c @@ -434,14 +434,14 @@ upcall_client_cache_invalidate (xlator_t *this, uuid_t gfid, up_client_entry->client_uid); } else { + gf_log (THIS->name, GF_LOG_TRACE, + "Cache invalidation notification NOT sent to %s", + up_client_entry->client_uid); + if (t_expired > (2*timeout)) { /* Cleanup the entry */ __upcall_cleanup_client_entry (up_client_entry); } - - gf_log (THIS->name, GF_LOG_TRACE, - "Cache invalidation notification NOT sent to %s", - up_client_entry->client_uid); } } |