summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCsaba Henk <csaba@redhat.com>2018-01-06 02:53:45 +0100
committerRaghavendra G <rgowdapp@redhat.com>2018-01-22 10:18:08 +0000
commitb1abe3c1baa5c132d32f7c6eedf3f9255534ed37 (patch)
tree35f90e7b502ac37f0e19c123d95853892664cd82
parentec3df9e65a3a2e1005cd4d50d06a8819fd3ab5f6 (diff)
performance/write-behind: volume option fixes for GD2
Updates #302 Change-Id: I2ade3dc4aef4da619c5b64058872594f0f1e004f Signed-off-by: Csaba Henk <csaba@redhat.com>
-rw-r--r--xlators/performance/write-behind/src/write-behind.c18
1 files changed, 18 insertions, 0 deletions
diff --git a/xlators/performance/write-behind/src/write-behind.c b/xlators/performance/write-behind/src/write-behind.c
index 2a2520147fe..5c85c872b95 100644
--- a/xlators/performance/write-behind/src/write-behind.c
+++ b/xlators/performance/write-behind/src/write-behind.c
@@ -3091,6 +3091,9 @@ struct volume_options options[] = {
{ .key = {"flush-behind"},
.type = GF_OPTION_TYPE_BOOL,
.default_value = "on",
+ .op_version = {1},
+ .flags = OPT_FLAG_SETTABLE | OPT_FLAG_DOC | OPT_FLAG_CLIENT_OPT,
+ .tags = {"write-behind"},
.description = "If this option is set ON, instructs write-behind "
"translator to perform flush in background, by "
"returning success (or any errors, if any of "
@@ -3102,28 +3105,43 @@ struct volume_options options[] = {
.min = 512 * GF_UNIT_KB,
.max = 1 * GF_UNIT_GB,
.default_value = "1MB",
+ .op_version = {1},
+ .flags = OPT_FLAG_SETTABLE | OPT_FLAG_DOC | OPT_FLAG_CLIENT_OPT,
+ .tags = {"write-behind"},
.description = "Size of the write-behind buffer for a single file "
"(inode)."
},
{ .key = {"trickling-writes"},
.type = GF_OPTION_TYPE_BOOL,
+ .op_version = {GD_OP_VERSION_3_13_1},
+ .flags = OPT_FLAG_SETTABLE | OPT_FLAG_DOC | OPT_FLAG_CLIENT_OPT,
+ .tags = {"write-behind"},
.default_value = "on",
},
{ .key = {"strict-O_DIRECT"},
.type = GF_OPTION_TYPE_BOOL,
.default_value = "off",
+ .op_version = {2},
+ .flags = OPT_FLAG_SETTABLE | OPT_FLAG_DOC | OPT_FLAG_CLIENT_OPT,
+ .tags = {"write-behind"},
.description = "This option when set to off, ignores the "
"O_DIRECT flag."
},
{ .key = {"strict-write-ordering"},
.type = GF_OPTION_TYPE_BOOL,
.default_value = "off",
+ .op_version = {2},
+ .flags = OPT_FLAG_SETTABLE | OPT_FLAG_DOC | OPT_FLAG_CLIENT_OPT,
+ .tags = {"write-behind"},
.description = "Do not let later writes overtake earlier writes even "
"if they do not overlap",
},
{ .key = {"resync-failed-syncs-after-fsync"},
.type = GF_OPTION_TYPE_BOOL,
.default_value = "off",
+ .op_version = {GD_OP_VERSION_3_7_7},
+ .flags = OPT_FLAG_SETTABLE | OPT_FLAG_DOC | OPT_FLAG_CLIENT_OPT,
+ .tags = {"write-behind"},
.description = "If sync of \"cached-writes issued before fsync\" "
"(to backend) fails, this option configures whether "
"to retry syncing them after fsync or forget them. "