diff options
| author | vmallika <vmallika@redhat.com> | 2015-07-10 16:04:16 +0530 |
|---|---|---|
| committer | Krishnan Parthasarathi <kparthas@redhat.com> | 2015-07-11 08:14:01 -0700 |
| commit | 35b2cdcb7ac0a623274b6cceac33c0f7fb16873b (patch) | |
| tree | 08b1da34e6c92025e3f07919c7ed37d3986ae1c6 | |
| parent | 93d8af231927d3476f8a966505a0e7fab7181385 (diff) | |
quota/marker: inspect file/dir invoked without having
quota xattrs requested
In a lookup and build ancestry quota xattrs are
not requested, it gives wrong assumption that
quota xattrs are missing and tries to do
healing process
Change-Id: I7135101ec0edc72a6310dbb304227eaa3b16cb46
BUG: 1207735
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11616
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
| -rw-r--r-- | xlators/features/marker/src/marker.c | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/xlators/features/marker/src/marker.c b/xlators/features/marker/src/marker.c index b5e41523747..4494595cc39 100644 --- a/xlators/features/marker/src/marker.c +++ b/xlators/features/marker/src/marker.c @@ -2714,6 +2714,10 @@ marker_lookup (call_frame_t *frame, xlator_t *this, priv = this->private; + xattr_req = xattr_req ? dict_ref (xattr_req) : dict_new (); + if (!xattr_req) + goto err; + if (priv->feature_enabled == 0) goto wind; @@ -2727,15 +2731,21 @@ marker_lookup (call_frame_t *frame, xlator_t *this, if (ret == -1) goto err; - if ((priv->feature_enabled & GF_QUOTA) && xattr_req) + if ((priv->feature_enabled & GF_QUOTA)) mq_req_xattr (this, loc, xattr_req, NULL); wind: STACK_WIND (frame, marker_lookup_cbk, FIRST_CHILD(this), FIRST_CHILD(this)->fops->lookup, loc, xattr_req); + + dict_unref (xattr_req); + return 0; err: STACK_UNWIND_STRICT (lookup, frame, -1, ENOMEM, NULL, NULL, NULL, NULL); + if (xattr_req) + dict_unref (xattr_req); + return 0; } @@ -2775,8 +2785,6 @@ marker_build_ancestry_cbk (call_frame_t *frame, void *cookie, xlator_t *this, continue; } - mq_xattr_state (this, &loc, entry->dict, entry->d_stat); - inode_unref (parent); parent = inode_ref (entry->inode); loc_wipe (&loc); |