diff options
| author | Eli Schwartz <eschwartz@archlinux.org> | 2018-12-04 11:38:48 -0500 |
|---|---|---|
| committer | Eli Schwartz <eschwartz@archlinux.org> | 2018-12-04 12:06:50 -0500 |
| commit | 82987486a9c9145caa6ce9ff31506ba2563a4a97 (patch) | |
| tree | 6b05f6b1640bd25c39c708c6ab5b52945861b67e | |
| parent | 9b770760d94b1fc39ade01df35dd3bcf317a71ed (diff) | |
configure.ac: fix option to stop automake aborting on pointless error
glusterfs does not follow the GNU coding standards and therefore must
use the "foreign" strictness. Without this, autoreconf -fi would fail to
execute successfully because automake returned non-zero.
This change ensures that people using autoreconf, the GNU preferred
invocation method for the autotools build system, can successfully set
up the build.
Remove the pointless --foreign argument from the autogen.sh invocation
of automake. Not only is configure.ac the preferred way to define such
options (rather than handwritten, piecemeal invocations of every tool in
the autotools toolchain), it was never needed in the autogen.sh as that
script provides no error handling at all and always (incorrectly)
returns successfully as long as autotools itself is installed (no matter
how broken glusterfs itself is).
Change-Id: Ib0246d5368a54594f517a322465cffb9a85c1b49
fixes: bz#1656100
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
| -rwxr-xr-x | autogen.sh | 2 | ||||
| -rw-r--r-- | configure.ac | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/autogen.sh b/autogen.sh index a4affc277bf..c8cdc3f89fa 100755 --- a/autogen.sh +++ b/autogen.sh @@ -85,7 +85,7 @@ $TOOL --automake --copy --force echo Running ${AUTOCONF}... $AUTOCONF echo Running ${AUTOMAKE}... -$AUTOMAKE --add-missing --force-missing --copy --foreign +$AUTOMAKE --add-missing --force-missing --copy # Instruct user on next steps echo diff --git a/configure.ac b/configure.ac index 43e8da3c2b2..110d6051838 100644 --- a/configure.ac +++ b/configure.ac @@ -13,7 +13,7 @@ AC_INIT([glusterfs], AC_SUBST([PACKAGE_RELEASE], [m4_esyscmd([build-aux/pkg-version --release])]) -AM_INIT_AUTOMAKE(tar-pax) +AM_INIT_AUTOMAKE([tar-pax foreign]) # Removes warnings when using automake 1.14 around (...but option 'subdir-objects' is disabled ) #but libglusterfs fails to build with contrib (Then are not set up that way?) |