summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmar Tumballi <amar@gluster.com>2010-09-27 02:06:26 +0000
committerVijay Bellur <vijay@dev.gluster.com>2010-09-27 10:47:43 -0700
commit542476b4bcf248c02ad087381c03c49c2b4c8014 (patch)
tree7c1abcf8e789a6ed1abb1ad8d63ae96e6966001a
parentc0cd0637bb8c28db5d3de0a89f312cad96ba2347 (diff)
access-control: handle a case of wrong error handling
in rename_src_stat_cbk(), we were checking the return value as '-1', but the function can return '-EFAULT' (ie, -14 in few cases). Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1691 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1691
-rw-r--r--xlators/features/access-control/src/access-control.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/features/access-control/src/access-control.c b/xlators/features/access-control/src/access-control.c
index b659a013309..7612266680f 100644
--- a/xlators/features/access-control/src/access-control.c
+++ b/xlators/features/access-control/src/access-control.c
@@ -1010,7 +1010,7 @@ ac_rename_src_stat_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
}
op_ret = ac_parent_loc_fill (&parentloc, &stub->args.rename.new);
- if (op_ret == -1) {
+ if (op_ret < 0) {
op_errno = -EFAULT;
goto out;
}