summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRaghavendra G <rgowdapp@redhat.com>2016-06-16 12:03:19 +0530
committerJeff Darcy <jdarcy@redhat.com>2016-07-05 05:46:06 -0700
commit8680261cbb7cacdc565feb578d6afd3fac50cec4 (patch)
tree84f6c0d3c164a78b3e5683c1c0cd8b3179b72469
parent807b9a135d697f175fc9933f1d23fb67b0cc6c7d (diff)
storage/posix: fix inode leaks
Change-Id: Ibd221ba62af4db17bea5c52d37f5c0ba30b60a7d BUG: 1344885 Signed-off-by: Raghavendra G <rgowdapp@redhat.com> Reviewed-on: http://review.gluster.org/14739 Smoke: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: N Balachandran <nbalacha@redhat.com> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com> Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
-rw-r--r--xlators/storage/posix/src/posix-handle.c2
-rw-r--r--xlators/storage/posix/src/posix.c5
2 files changed, 6 insertions, 1 deletions
diff --git a/xlators/storage/posix/src/posix-handle.c b/xlators/storage/posix/src/posix-handle.c
index 8e561e4a76f..ddafb0d9b04 100644
--- a/xlators/storage/posix/src/posix-handle.c
+++ b/xlators/storage/posix/src/posix-handle.c
@@ -989,6 +989,8 @@ posix_create_link_if_gfid_exists (xlator_t *this, uuid_t gfid, char *real_path,
}
unlock:
UNLOCK (&inode->lock);
+
+ inode_unref (inode);
}
return ret;
diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c
index a362e633297..0d4bad96141 100644
--- a/xlators/storage/posix/src/posix.c
+++ b/xlators/storage/posix/src/posix.c
@@ -6186,8 +6186,11 @@ posix_readdirp_fill (xlator_t *this, fd_t *fd, gf_dirent_t *entries, dict_t *dic
ret = posix_pstat (this, gfid, hpath, &stbuf);
- if (ret == -1)
+ if (ret == -1) {
+ if (inode)
+ inode_unref (inode);
continue;
+ }
if (!inode)
inode = inode_find (itable, stbuf.ia_gfid);