diff options
| author | Ira Cooper <ira@samba.org> | 2014-01-21 22:46:59 -0500 |
|---|---|---|
| committer | Anand Avati <avati@redhat.com> | 2014-01-24 23:49:37 -0800 |
| commit | 1968ec12e62a22fc6e55c4bcc7170d036bf28932 (patch) | |
| tree | 8b08e773a581cb5c3a6323f6ccec9ea5445bcda3 | |
| parent | c0ac21222383315b9fe84ac7c0afdf01e3ecef7b (diff) | |
mgmt: Fix memory leak of brickid from gf_asprintf.
No GF_FREE, so one was put into the return path with proper checking.
Change-Id: Idde2803608409dcbf216062f83b7f4493946ba70
CID: 1124718
BUG: 789278
Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-on: http://review.gluster.org/6755
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-utils.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c index 4a88b5b3523..384a974d91b 100644 --- a/xlators/mgmt/glusterd/src/glusterd-utils.c +++ b/xlators/mgmt/glusterd/src/glusterd-utils.c @@ -1295,11 +1295,14 @@ glusterd_brick_connect (glusterd_volinfo_t *volinfo, glusterd_brick_rpc_notify, brickid); synclock_lock (&priv->big_lock); - if (ret) + if (ret) { + GF_FREE (brickid); goto out; + } brickinfo->rpc = rpc; } out: + gf_log ("", GF_LOG_DEBUG, "Returning %d", ret); return ret; } |