diff options
| author | Oshank Kumar <okumar@redhat.com> | 2018-07-24 16:26:18 +0530 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2018-07-24 16:24:14 +0000 |
| commit | 59401e705b9432345f3b449b50cfa4095ce2169a (patch) | |
| tree | 2e687dd8a23fe244f1c23c30b3ac16d1ae5a17f3 | |
| parent | 5fa004f3c4924dd6d83aecd5f33fc58badbe9305 (diff) | |
glusterd: Deadcode Coverity issue
This patch will fix coverity issue 74 from [1].
we are updating ret value line number 5011, and
immediately checking whether ret is having non
zero value at line number 5013.If ret is 0, then
only we continue to execute and we can reach line
number 5036. By the time we reach 5036, ret value
is always 0. So this block of code is redundant
here and removing it.
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2018-07-23-5fa004f3/html/
Updates: bz#789278
Change-Id: Ia6e8ba2936e350f0d29a9151ab786622f5e750db
Signed-off-by: Oshank Kumar <okumar@redhat.com>
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-utils.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c index 6be40ef8c02..dc8e1bdfd80 100644 --- a/xlators/mgmt/glusterd/src/glusterd-utils.c +++ b/xlators/mgmt/glusterd/src/glusterd-utils.c @@ -5033,8 +5033,6 @@ glusterd_compare_friend_data (dict_t *peer_data, int32_t *status, glusterd_launch_synctask (glusterd_import_friend_volumes_synctask, peer_data_copy); - if (ret) - goto out; } out: |