diff options
| author | Mohammed Rafi KC <rkavunga@redhat.com> | 2015-03-25 15:11:48 +0530 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2015-04-09 12:45:08 +0000 |
| commit | e405f6e419387d160f6564d15ad9fd3a43af0d10 (patch) | |
| tree | 5c9a3c928ffa7b770ba96c1148206b08ccf003b7 | |
| parent | e0de0cd9b24169b90c95e1f6a87f05c060185089 (diff) | |
Snapshot: Remove brick details on snapshot create error
Since we are not providing complete details of stopped
bricks on snapshot create error, it is better to remove
the incomplete brick details.
BUG: 1205596
Change-Id: I73386059c0d29a6cbe7f2bb6834d8b8fb393db0a
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/9999
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-snapshot.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-snapshot.c b/xlators/mgmt/glusterd/src/glusterd-snapshot.c index f20a12b25d9..6d1f79b65d0 100644 --- a/xlators/mgmt/glusterd/src/glusterd-snapshot.c +++ b/xlators/mgmt/glusterd/src/glusterd-snapshot.c @@ -1879,20 +1879,22 @@ glusterd_snap_create_clone_common_prevalidate (dict_t *rsp_dict, int flags, } if (!clone) { snprintf (err_str, PATH_MAX, - "brick %s:%s is not started. " + "One or more bricks are not running. " + "Please run volume status command to see " + "brick status.\n" "Please start the stopped brick " "and then issue snapshot create " "command or use [force] option in " "snapshot create to override this " - "behavior.", brickinfo->hostname, - brickinfo->path); + "behavior."); } else { snprintf (err_str, PATH_MAX, - "brick %s:%s is not started. " + "One or more bricks are not running. " + "Please run snapshot status command to see " + "brick status.\n" "Please start the stopped brick " "and then issue snapshot clone " - "command ", brickinfo->hostname, - brickinfo->path); + "command "); } ret = -1; goto out; |