summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVijay Bellur <vbellur@redhat.com>2014-12-17 13:19:00 +0530
committerVijay Bellur <vbellur@redhat.com>2015-01-16 01:03:41 -0800
commit9ab533ff86dbf914b47228a9326fefd9ba04c65f (patch)
treedca83363b99fcaa0f840f1672d428f2bc54eacff
parenta3bc6cf85d20ab21380f96f8d11cad29a53b3bb4 (diff)
protocol/client: Prevent "Dereference after NULL check" errors.
Fixes 46 defects marked as "Dereference after NULL check" errors in coverity scan for client xlator. Change-Id: I0b4c991a3995ce74d7885fc5470ec7f5c589b411 BUG: 789278 Signed-off-by: Vijay Bellur <vbellur@redhat.com> Reviewed-on: http://review.gluster.org/9287 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com> Reviewed-by: Niels de Vos <ndevos@redhat.com>
-rw-r--r--xlators/protocol/client/src/client.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/xlators/protocol/client/src/client.h b/xlators/protocol/client/src/client.h
index 69f77570cd0..b4809310939 100644
--- a/xlators/protocol/client/src/client.h
+++ b/xlators/protocol/client/src/client.h
@@ -57,6 +57,8 @@ typedef enum {
} while (0)
#define CLIENT_STACK_UNWIND(op, frame, params ...) do { \
+ if (!frame) \
+ break; \
clnt_local_t *__local = frame->local; \
frame->local = NULL; \
STACK_UNWIND_STRICT (op, frame, params); \