diff options
| author | Mohit Agrawal <moagrawa@redhat.com> | 2018-05-29 14:57:44 +0530 |
|---|---|---|
| committer | Mohit Agrawal <moagrawa@redhat.com> | 2018-05-29 17:21:28 +0530 |
| commit | 052fce3f31d856fce10e07eda5f5c49ad3390d3a (patch) | |
| tree | 90c852616115e454bc0213ac7aa8b218c6356311 | |
| parent | df838299a8a1732cff9972c9f2377e9c2a4844a0 (diff) | |
dht: Excessive 'dict is null' logs in dht_revalidate_cbk
Problem: In case of error(ESTALE/ENOENT) dht_revalidate_cbk
throws "dict is null" error because xattr is not available
Solution: To avoid the logs update condition in dht_revalidate_cbk
and dht_lookup_dir_cbk
BUG: 1583565
Change-Id: Ife6b3eeb6d91bf24403ed3100e237bb5d15b4357
fixes: bz#1583565
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
| -rw-r--r-- | xlators/cluster/dht/src/dht-common.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/xlators/cluster/dht/src/dht-common.c b/xlators/cluster/dht/src/dht-common.c index c436ad48d9d..fdf10d5cfed 100644 --- a/xlators/cluster/dht/src/dht-common.c +++ b/xlators/cluster/dht/src/dht-common.c @@ -1505,7 +1505,8 @@ unlock: DHT_STRIP_PHASE1_FLAGS (&local->stbuf); dht_set_fixed_dir_stat (&local->postparent); /* Delete mds xattr at the time of STACK UNWIND */ - GF_REMOVE_INTERNAL_XATTR (conf->mds_xattr_key, local->xattr); + if (local->xattr) + GF_REMOVE_INTERNAL_XATTR (conf->mds_xattr_key, local->xattr); DHT_STACK_UNWIND (lookup, frame, local->op_ret, local->op_errno, local->inode, &local->stbuf, local->xattr, &local->postparent); @@ -1908,7 +1909,8 @@ cont: local->op_errno = ESTALE; } /* Delete mds xattr at the time of STACK UNWIND */ - GF_REMOVE_INTERNAL_XATTR (conf->mds_xattr_key, local->xattr); + if (local->xattr) + GF_REMOVE_INTERNAL_XATTR (conf->mds_xattr_key, local->xattr); DHT_STACK_UNWIND (lookup, frame, local->op_ret, local->op_errno, local->inode, &local->stbuf, local->xattr, |