diff options
author | Kaushik BV <kaushikbv@gluster.com> | 2011-03-13 23:33:13 +0000 |
---|---|---|
committer | Vijay Bellur <vijay@dev.gluster.com> | 2011-03-14 03:09:01 -0700 |
commit | 3145f70fc27d8259b885049bcf7a737f4b7de569 (patch) | |
tree | a3f81a40accd666e321ae8d0247d86e000329cf3 | |
parent | 05dbcd0cb2415bb218221eccc1e7005645aa318b (diff) |
mgmt/Glusterd: remove the checks performed for all ops in brick_op
Signed-off-by: Kaushik BV <kaushikbv@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2427 (set a proper default for remote syncdaemon)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2427
-rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-op-sm.c | 21 |
1 files changed, 2 insertions, 19 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c b/xlators/mgmt/glusterd/src/glusterd-op-sm.c index 5fbf7c845cc..067956280c1 100644 --- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c +++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c @@ -6383,25 +6383,10 @@ glusterd_op_bricks_select (glusterd_op_t op, dict_t *dict, char **op_errstr) GF_ASSERT (dict); GF_ASSERT (op_errstr); + GF_ASSERT (op > GD_OP_NONE); + GF_ASSERT (op < GD_OP_MAX); switch (op) { - case GD_OP_CREATE_VOLUME: - case GD_OP_START_BRICK: - case GD_OP_STOP_BRICK: - case GD_OP_DELETE_VOLUME: - case GD_OP_START_VOLUME: - case GD_OP_RENAME_VOLUME: - case GD_OP_DEFRAG_VOLUME: - case GD_OP_ADD_BRICK: - case GD_OP_REPLACE_BRICK: - case GD_OP_SET_VOLUME: - case GD_OP_RESET_VOLUME: - case GD_OP_SYNC_VOLUME: - case GD_OP_LOG_FILENAME: - case GD_OP_LOG_LOCATE: - case GD_OP_LOG_ROTATE: - //nothing to be done - break; case GD_OP_STOP_VOLUME: ret = glusterd_bricks_select_stop_volume (dict, op_errstr); break; @@ -6415,8 +6400,6 @@ glusterd_op_bricks_select (glusterd_op_t op, dict_t *dict, char **op_errstr) break; default: - gf_log ("", GF_LOG_ERROR, "Unknown op %d", op); - ret = -1; break; } |