summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNiels de Vos <ndevos@redhat.com>2017-05-30 13:10:50 +0530
committerShyamsundar Ranganathan <srangana@redhat.com>2017-05-30 13:02:22 +0000
commitf618c7e606caaf8371aea4a02b352c987b3b1a40 (patch)
tree8f6df0c6e36cf7e835a57540e753edb5fac0daca
parent1b1f871ca41b08671ebb327dba464aeb6c82e776 (diff)
scripts: prevent a script warning if rfc.sh does not find a backport
When running ./rfc.sh on a branch to post release notes (not a backport from master), then the following script warning is displayed: ./rfc.sh: line 97: [: =: unary operator expected In case the used variables are not set, they are not handled as empty strings. Placing the variables inside "${qoutes}" prevents this warning. BUG: 1428047 Change-Id: Ie171d6f66b47401d6ea4e78aa3ed2bd0c6fce9ce Signed-off-by: Niels de Vos <ndevos@redhat.com> Reviewed-on: https://review.gluster.org/17418 Smoke: Gluster Build System <jenkins@build.gluster.org> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
-rwxr-xr-xrfc.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/rfc.sh b/rfc.sh
index 07d61ea95ae..0123a220776 100755
--- a/rfc.sh
+++ b/rfc.sh
@@ -94,7 +94,7 @@ check_backport()
# NOTE: If master was not rebased, we will not find the Change-ID and
# could hit a false positive case here (or if someone checks out some
# other branch as master).
- if [ $mchangeid = $changeid ]; then
+ if [ "${mchangeid}" = "${changeid}" ]; then
moveon="Y"
else
backport_id_message;