libglusterfs, gfdb, glusterfs: Add missing breaks

A few switches did not have breaks causing fall throughs. Most of them
have been fixed with fall through comments for those that are
intentional.

Change-Id: I84c85726b542f38504b50fefab5eba5dbcd27a07
BUG: 1424894
Signed-off-by: Nigel Babu <nigelb@redhat.com>
Reviewed-on: https://review.gluster.org/16677
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>

8 files changed, 12 insertions, 0 deletions

diff --git a/libglusterfs/src/call-stub.c b/libglusterfs/src/call-stub.c
index c9c47b56c98..9aa67aab6c2 100644
--- a/libglusterfs/src/call-stub.c
+++ b/libglusterfs/src/call-stub.c
@@ -2218,11 +2218,13 @@ call_resume_wind (call_stub_t *stub)
         case GF_FOP_GETACTIVELK:
                 stub->fn.getactivelk (stub->frame, stub->frame->this,
                                        &stub->args.loc, stub->args.xdata);
+                break;
 
         case GF_FOP_SETACTIVELK:
                 stub->fn.setactivelk (stub->frame, stub->frame->this,
                                         &stub->args.loc, &stub->args.locklist,
                                         stub->args.xdata);
+                break;
 
         default:
                 gf_msg_callingfn ("call-stub", GF_LOG_ERROR, EINVAL,
@@ -2445,9 +2447,11 @@ call_resume_unwind (call_stub_t *stub)
         case GF_FOP_GETACTIVELK:
                 STUB_UNWIND (stub, getactivelk, &stub->args_cbk.locklist,
                              stub->args_cbk.xdata);
+                break;
 
         case GF_FOP_SETACTIVELK:
                 STUB_UNWIND (stub, setactivelk, stub->args_cbk.xdata);
+                break;
 
         default:
                 gf_msg_callingfn ("call-stub", GF_LOG_ERROR, EINVAL,
diff --git a/libglusterfs/src/common-utils.c b/libglusterfs/src/common-utils.c
index 1e77ebe6f29..51f97442fec 100644
--- a/libglusterfs/src/common-utils.c
+++ b/libglusterfs/src/common-utils.c
@@ -4517,6 +4517,8 @@ fop_enum_to_string (glusterfs_fop_t fop)
                 "IPC",
                 "SEEK",
                 "COMPOUND",
+                "GETACTIVELK",
+                "SETACTIVELK",
                 "MAXVALUE"};
         if (fop <= GF_FOP_MAXVALUE)
                 return str_map[fop];
diff --git a/libglusterfs/src/gfdb/gfdb_sqlite3.c b/libglusterfs/src/gfdb/gfdb_sqlite3.c
index 70e38855fde..16930504742 100644
--- a/libglusterfs/src/gfdb/gfdb_sqlite3.c
+++ b/libglusterfs/src/gfdb/gfdb_sqlite3.c
@@ -1456,6 +1456,7 @@ gf_sqlite3_vacuum (void *db_conn, gf_boolean_t compact_active,
                                 break;
                         case GF_SQL_COMPACT_MANUAL:
                                 changing_pragma = _gf_false;
+                                break;
                         default:
                                 ret = -1;
                                 gf_msg (GFDB_STR_SQLITE3, GF_LOG_ERROR, 0,
diff --git a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
index 2efa31b814f..7e993e7a231 100644
--- a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
+++ b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
@@ -2924,6 +2924,7 @@ glusterd_op_remove_brick (dict_t *dict, char **op_errstr)
         case GF_DEFRAG_STATUS_FAILED:
         case GF_DEFRAG_STATUS_COMPLETE:
                 volinfo->rebal.defrag_status = 0;
+        /* FALLTHROUGH */
         default:
                 break;
         }
diff --git a/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c b/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c
index acb24fff187..b57542a85a7 100644
--- a/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c
+++ b/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c
@@ -419,6 +419,7 @@ glusterd_snapdsvc_rpc_notify (glusterd_conn_t *conn, rpc_clnt_event_t event)
 
         case RPC_CLNT_DESTROY:
                 glusterd_volinfo_unref (volinfo);
+                break;
 
         default:
                 gf_msg_trace (this->name, 0,
diff --git a/xlators/mgmt/glusterd/src/glusterd-syncop.c b/xlators/mgmt/glusterd/src/glusterd-syncop.c
index 07501f2407d..e5fba968c07 100644
--- a/xlators/mgmt/glusterd/src/glusterd-syncop.c
+++ b/xlators/mgmt/glusterd/src/glusterd-syncop.c
@@ -320,6 +320,7 @@ glusterd_syncop_aggr_rsp_dict (glusterd_op_t op, dict_t *aggr, dict_t *rsp)
         case GD_OP_DETACH_TIER_STATUS:
         case GD_OP_REMOVE_TIER_BRICK:
                 ret = glusterd_volume_tier_use_rsp_dict (aggr, rsp);
+        /* FALLTHROUGH */
         default:
         break;
         }
diff --git a/xlators/mgmt/glusterd/src/glusterd-tier.c b/xlators/mgmt/glusterd/src/glusterd-tier.c
index 0afdab56c9c..5f9a08f1909 100644
--- a/xlators/mgmt/glusterd/src/glusterd-tier.c
+++ b/xlators/mgmt/glusterd/src/glusterd-tier.c
@@ -718,6 +718,7 @@ glusterd_op_remove_tier_brick (dict_t *dict, char **op_errstr, dict_t *rsp_dict)
         case GF_DEFRAG_STATUS_FAILED:
         case GF_DEFRAG_STATUS_COMPLETE:
                 volinfo->tier.defrag_status = 0;
+        /* FALLTHROUGH */
         default:
                 break;
         }
diff --git a/xlators/protocol/client/src/client-helpers.c b/xlators/protocol/client/src/client-helpers.c
index 425c73fb1a5..f9d5c2c8b12 100644
--- a/xlators/protocol/client/src/client-helpers.c
+++ b/xlators/protocol/client/src/client-helpers.c
@@ -1437,6 +1437,7 @@ client_handle_fop_requirements (xlator_t *this, call_frame_t *frame,
                                 &this_req->compound_req_u.compound_lease_req,
                                 op_errno, out, &args->loc, &args->lease,
                                 args->xdata);
+                break;
         default:
                 return ENOTSUP;
         }