diff options
author | Amar Tumballi <amarts@redhat.com> | 2018-07-03 11:47:31 +0530 |
---|---|---|
committer | Amar Tumballi <amarts@redhat.com> | 2018-07-06 08:12:56 +0000 |
commit | 340500cc9533cfe9ccae08f049502aefa7534b4c (patch) | |
tree | 11d22e95cdd3200f21fa75f390ae10100be118e0 | |
parent | 99a1e816ceae107694fa14d755cec91e159f0a2d (diff) |
checkpatch.pl: fix the perl warning
Used to get the below warning:
`
Running coding guidelines check ...
Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.30), passed through in regex; marked by <-- HERE in m/^(\+.*(?:do|\))){ <-- HERE / at ./build-aux/checkpatch.pl line 3102.
`
But as per the recommendation in perl document, we should escape the braces.
While this check should be removed from the codebase when we get the 'codingstandard' automated scripts, we can keep the code warning free at least till then.
updates: bz#1193929
Change-Id: I236a428174b5d16ca41baa03e96bc7aa26177b5b
Signed-off-by: Amar Tumballi <amarts@redhat.com>
-rwxr-xr-x | build-aux/checkpatch.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/build-aux/checkpatch.pl b/build-aux/checkpatch.pl index 205567307b1..17ae4e4d579 100755 --- a/build-aux/checkpatch.pl +++ b/build-aux/checkpatch.pl @@ -3099,7 +3099,7 @@ sub process { if (ERROR("SPACING", "space required before the open brace '{'\n" . $herecurr) && $fix) { - $fixed[$linenr - 1] =~ s/^(\+.*(?:do|\))){/$1 {/; + $fixed[$linenr - 1] =~ s/^(\+.*(?:do|\)))\{/$1 {/; } } |