diff options
| author | Mohammed Rafi KC <rkavunga@redhat.com> | 2015-06-01 16:53:32 +0530 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2015-06-22 00:48:36 -0700 |
| commit | f6a8d810b64e65bf127f5e0ab566abe250beed08 (patch) | |
| tree | aacd8cfdf432b154d1c596efe2b977d8c26c96e7 | |
| parent | 94481b51a89176f8e43f3d4a6de46e93321bf1b4 (diff) | |
tiering:static function called from a non static inline function
Backport of http://review.gluster.org/#/c/11032/
gcc v5.1.1 throws warning for calling a static function from
a non-static inline function.
<snippet from compiler warning>
CC tier.lo
tier.c:610:15: warning: 'tier_migrate_using_query_file' is static but used in inline function 'tier_migrate_files_using_qfile' which is not static
ret = tier_migrate_using_query_file ((void *)query_cbk_args);
^
tier.c:585:47: warning: 'tier_process_brick_cbk' is static but used in inline function 'tier_build_migration_qfile' which is not static
ret = dict_foreach (args->brick_list, tier_process_brick_cbk,
^
tier.c:565:176: warning: 'demotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
tier.c:565:158: warning: 'promotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
tier.c:563:58: warning: 'demotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
tier.c:563:40: warning: 'promotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
ret = remove (GET_QFILE_PATH (is_promotion));
^
CCLD tier.la
</snip>
Change-Id: I46046feeb79ab4e2724b0ba6b02c9ec8b121ff4e
BUG: 1231767
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/11232
Reviewed-by: Joseph Fernandes
Tested-by: Joseph Fernandes
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
| -rw-r--r-- | xlators/cluster/dht/src/tier.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/cluster/dht/src/tier.c b/xlators/cluster/dht/src/tier.c index 6c5dfeb0501..3e1b20eaedc 100644 --- a/xlators/cluster/dht/src/tier.c +++ b/xlators/cluster/dht/src/tier.c @@ -548,7 +548,7 @@ out: return ret; } -inline int +static inline int tier_build_migration_qfile (demotion_args_t *args, query_cbk_args_t *query_cbk_args, gf_boolean_t is_promotion) @@ -597,7 +597,7 @@ out: return ret; } -inline int +static inline int tier_migrate_files_using_qfile (demotion_args_t *comp, query_cbk_args_t *query_cbk_args, char *qfile) |