diff options
author | Pranith Kumar K <pranithk@gluster.com> | 2012-03-10 00:54:12 +0530 |
---|---|---|
committer | Vijay Bellur <vijay@gluster.com> | 2012-03-13 04:58:45 -0700 |
commit | fa5b0347193f8d1a4b917a2edb338423cb175e66 (patch) | |
tree | 4f24b9cc0bae934c71e4684ef1f1104322f3bcec /CONTRIBUTING | |
parent | 4a37d78da3fef69f0074cab3ff71182a68876358 (diff) |
protocol/server: Remove connection from conf->conns w.o. race
1) Adding the connection to conf->conns used to
happen in conf->mutex, but removing happened under conn->lock.
Fixed that as below.
When the connection object is created conn's ref, bind_ref count
is set to '1'. For bind_ref ref/unref happens under conf->mutex
whenever server_connection_get, put is called.
When bind_ref goes to '0' connection object is removed from
conf->conns under conf->mutex. After it is removed from the list,
conn_unref is called outside the conf->mutex.
conn_ref/unref still happens under conn->lock.
2) Fixed races in server_connection_cleaup in grace_timer_handler
and server_setvolume.
Change-Id: Ie7b63b10f658af909a11c3327066667f5b7bd114
BUG: 801675
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/2911
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Diffstat (limited to 'CONTRIBUTING')
0 files changed, 0 insertions, 0 deletions