diff options
author | Atin Mukherjee <amukherj@redhat.com> | 2017-07-05 14:58:50 +0530 |
---|---|---|
committer | Niels de Vos <ndevos@redhat.com> | 2017-08-10 16:45:29 +0000 |
commit | b7b13c8cd295fa2e9fba9cc77211e576469e9581 (patch) | |
tree | f38009c29d6ba4e0ae9664b7812eea1da38771ef /CONTRIBUTING | |
parent | 982480ecbc0085d4e6bbbc976d2549abbd5f3e61 (diff) |
cli/xml: fix return handling
The return code of xmlTextWriter* APIs says it returns either the bytes
written (may be 0 because of buffering) or -1 in case of error. Now if the
volume of the xml data payload is not huge then most of the time the
data to be written gets buffered, however when this grows sometimes this
APIs will return the total number of bytes written and then it becomes
absolutely mandatory that every such call is followed by
XML_RET_CHECK_AND_GOTO otherwise we may end up returning a non zero ret
code which would result into the overall xml generation to fail.
>Reviewed-on: https://review.gluster.org/17702
>Smoke: Gluster Build System <jenkins@build.gluster.org>
>Reviewed-by: Amar Tumballi <amarts@redhat.com>
>CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
>Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
Change-Id: I02ee7076e1d8c26cf654d3dc3e77b1eb17cbdab0
BUG: 1470495
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/17766
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'CONTRIBUTING')
0 files changed, 0 insertions, 0 deletions