diff options
| author | Niels de Vos <ndevos@redhat.com> | 2015-05-18 16:26:02 +0200 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2015-05-29 05:43:17 -0700 |
| commit | 8a9328e37b8c63d60583184dc8dab12f85810682 (patch) | |
| tree | 0fa017379bf5e9dfaa2e6d8132c73cc1090a3d52 /api | |
| parent | 5d912230a7d4f9979c10ff15da724624bd8e069d (diff) | |
build: do not #include "config.h" in each file
Instead of including config.h in each file, and have the additional
config.h included from the compiler commandline (-include option).
When a .c file tests for a certain #define, and config.h was not
included, incorrect assumtions were made. With this change, it can not
happen again.
BUG: 1222319
Change-Id: I4f9097b8740b81ecfe8b218d52ca50361f74cb64
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10808
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Diffstat (limited to 'api')
| -rw-r--r-- | api/src/gfapi-messages.h | 5 | ||||
| -rw-r--r-- | api/src/glfs-master.c | 5 | ||||
| -rw-r--r-- | api/src/glfs-mgmt.c | 5 | ||||
| -rw-r--r-- | api/src/glfs-resolve.c | 5 | ||||
| -rw-r--r-- | api/src/glfs.c | 5 |
5 files changed, 0 insertions, 25 deletions
diff --git a/api/src/gfapi-messages.h b/api/src/gfapi-messages.h index 2c59af24113..4c9b3f66221 100644 --- a/api/src/gfapi-messages.h +++ b/api/src/gfapi-messages.h @@ -11,11 +11,6 @@ #ifndef _GFAPI_MESSAGES_H__ #define _GFAPI_MESSAGES_H_ -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #include "glfs-message-id.h" /*! \file gfapi-messages.h diff --git a/api/src/glfs-master.c b/api/src/glfs-master.c index 11843c15b4d..bb657695489 100644 --- a/api/src/glfs-master.c +++ b/api/src/glfs-master.c @@ -15,11 +15,6 @@ #include <inttypes.h> #include <limits.h> -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #include "xlator.h" #include "glusterfs.h" diff --git a/api/src/glfs-mgmt.c b/api/src/glfs-mgmt.c index 2159d6795ad..d69c3fc1883 100644 --- a/api/src/glfs-mgmt.c +++ b/api/src/glfs-mgmt.c @@ -16,11 +16,6 @@ #include <signal.h> #include <pthread.h> -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif /* _CONFIG_H */ - #include "glusterfs.h" #include "glfs.h" #include "stack.h" diff --git a/api/src/glfs-resolve.c b/api/src/glfs-resolve.c index 60e285d3ae7..287c48a13ad 100644 --- a/api/src/glfs-resolve.c +++ b/api/src/glfs-resolve.c @@ -16,11 +16,6 @@ #include <inttypes.h> #include <limits.h> -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #include "glusterfs.h" #include "logging.h" #include "stack.h" diff --git a/api/src/glfs.c b/api/src/glfs.c index 5653f4d46c0..fc392947e1e 100644 --- a/api/src/glfs.c +++ b/api/src/glfs.c @@ -33,11 +33,6 @@ #include <unistd.h> #include <limits.h> -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #include "glusterfs.h" #include "logging.h" #include "stack.h" |