diff options
| author | Nandaja Varma <nvarma@redhat.com> | 2015-02-04 13:21:50 +0530 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2015-03-31 01:35:34 -0700 |
| commit | 6df8d1d8781f59fbab46c4b016dde0b2d33dd189 (patch) | |
| tree | ba481f69fb88294f69926c2b7fd0279014c9bd12 /cli/src/cli-cmd-volume.c | |
| parent | e92270044e358ca5b290557026fab32f5d8368e9 (diff) | |
gluster-cli: Fixing operand error and removing logically dead code.
Assign used instead of comparison
Coverity CIDs:
1124391
1124346
1124369
1124370
1124702
1124390
1124397
Change-Id: If015382917cad65edc2fee38ae6328f1d072d6f6
BUG: 789278
Signed-off-by: Nandaja Varma <nvarma@redhat.com>
Reviewed-on: http://review.gluster.org/9574
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'cli/src/cli-cmd-volume.c')
| -rw-r--r-- | cli/src/cli-cmd-volume.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/cli/src/cli-cmd-volume.c b/cli/src/cli-cmd-volume.c index 8c9cdf43fe3..5436c76bcc2 100644 --- a/cli/src/cli-cmd-volume.c +++ b/cli/src/cli-cmd-volume.c @@ -374,12 +374,6 @@ cli_cmd_volume_start_cbk (struct cli_state *state, struct cli_cmd_word *word, goto out; } - if (ret < 0) { - gf_log (THIS->name, GF_LOG_ERROR, - "failed to serialize dict"); - goto out; - } - proc = &cli_rpc_prog->proctable[GLUSTER_CLI_START_VOLUME]; CLI_LOCAL_INIT (local, words, frame, dict); @@ -2414,7 +2408,7 @@ cli_cmd_volume_clearlocks_cbk (struct cli_state *state, out: if (ret) { cli_cmd_sent_status_get (&sent); - if ((sent == 0) && (parse_error = 0)) + if ((sent == 0) && (parse_error == 0)) cli_out ("Volume clear-locks failed"); } |