diff options
author | Emmanuel Dreyfus <manu@netbsd.org> | 2015-04-08 10:49:07 +0200 |
---|---|---|
committer | Vijay Bellur <vbellur@redhat.com> | 2015-04-11 18:11:11 +0000 |
commit | d10bd788fada54ad095e19b5aedf949e23fdabb2 (patch) | |
tree | 3cace28691af65cd2ffea104e6f36c80f7cf09e7 /configure.ac | |
parent | 169ea3e4939b79e5f658d44ac190221324a8967f (diff) |
crypt xlator: Fix memory coruption after free
crypt xlator allocated local memory through mem_get0(), but code called
through STACK_DESTROY()/FRAME_DESTROY() does not expect memory to be
allocated that way: it will use GF_FREE() even for data allocated by
mem_get0(), which should be given the mem_put() treatment. As a result,
allocating using mem_get0(), while relying on FRAME_DESTROY() cleanup
led to memory corruption.
Using GF_CALLOC() instead of mem_get0() sets memory allocation on par
with cleanup code, and crypt.t can pass on NetBSD.
The initial patch was crafted by Raghavendra Talur.
BUG: 1129939
Change-Id: Ib71b4b57f8d1bb782f950e3c8fa74a4f7e10946e
Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org>
Reviewed-on: http://review.gluster.org/10109
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'configure.ac')
0 files changed, 0 insertions, 0 deletions