diff options
author | Krutika Dhananjay <kdhananj@redhat.com> | 2012-09-03 15:53:40 +0530 |
---|---|---|
committer | Vijay Bellur <vbellur@redhat.com> | 2012-09-05 07:42:14 -0700 |
commit | a06a074b8cf3444acabca9003ae98539029453b0 (patch) | |
tree | 9b4a821e0883c150244e0dd662734d1b6c6b5747 /configure.ac | |
parent | b80158698405f198a3d2b77ee5817d1096740600 (diff) |
glusterd: Removed pattern match lookup logic on volume options
In light of the comments received on the following patch,
http://review.gluster.com/#change,3860
this change knocks off the pattern match lookup logic that once
enabled wildcard entries to be used for volume options.
Here's a bit on the history of the macro "pattern_match_options",
coming straight from the author's(Csaba) mouth:
"So, the history of pattern_match_options is as follows:
i. In the volume option table we used to be able to have wildcard
entries like auth.addr.*.allow and there was a special lookup logic
to support that, cf.
http://github.com/gluster/glusterfs/commit/v3.1.0qa40~19
ii. However, later on we stopped using this mechanism:
http://github.com/gluster/glusterfs/commit/v3.1.0qa40~9
iii. Later on we added the code that allowed the usage of option
names both in fully qualified (<domain>.<specifier>) and short
(<specifier>)forms:
http://github.com/gluster/glusterfs/commit/v3.1.0qa41~10.
At this point, maintaining support for wildcard table entries became
more difficult (~ error prone), so that part was placed under the macro
pattern_match_options and -- given that we made no use of the feature
-- a simple direct lookup logic was introduced. I chose to keep the
pattern matching logic in the code because I was not really sure about
the future of it and thought we might want wildcarded table entries
later. ..."
Change-Id: I261735143891931e8150c36fe5b33ae74b1c663d
BUG: 847846
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: http://review.gluster.org/3893
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Csaba Henk <csaba@redhat.com>
Diffstat (limited to 'configure.ac')
0 files changed, 0 insertions, 0 deletions