diff options
author | Brian Foster <bfoster@redhat.com> | 2013-10-18 07:36:38 -0400 |
---|---|---|
committer | Anand Avati <avati@redhat.com> | 2013-11-10 23:45:46 -0800 |
commit | b06ecde2997b72a41b2f2d25d55e61d30ea46bc2 (patch) | |
tree | ff630d050b46310141d0ca11ee56b04736d06cea /contrib/qemu/config-host.h | |
parent | 0826f9073a93c6d499f3d2077695455854d0fa7f (diff) |
features/qemu-block: simplify coroutine model to use single synctask, ucontext
The current coroutine model, mapping synctasks 1-1 with qemu internal
Coroutines, has some unresolved raciness issues. This problem usually
manifests as lifecycle mismatches between top-level (gluster created)
synctasks and the subsequently created internal coroutines from that
context. Qemu's internal queueing (and locking) can cause situations
where the top-level synctask is destroyed before the internal scheduler
has released references to memory, leading to use after free crashes
and asserts.
Simplify the coroutine model to use a single synctask as a coroutine
processor and rely on the existing native ucontext coroutine
implementation. The syncenv thread is donated to qemu and ensures a
single top-level coroutine is processed at a time. Qemu now has
complete control over coroutine scheduling.
BUG: 986775
Change-Id: I38223479a608d80353128e390f243933fc946fd6
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-on: http://review.gluster.org/6110
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Diffstat (limited to 'contrib/qemu/config-host.h')
-rw-r--r-- | contrib/qemu/config-host.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/contrib/qemu/config-host.h b/contrib/qemu/config-host.h index 874b04053bc..46b1595a806 100644 --- a/contrib/qemu/config-host.h +++ b/contrib/qemu/config-host.h @@ -64,7 +64,6 @@ #define CONFIG_OPEN_BY_HANDLE 1 #define CONFIG_LINUX_MAGIC_H 1 #define CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE 1 -#define CONFIG_VALGRIND_H 1 #define CONFIG_HAS_ENVIRON 1 #define CONFIG_CPUID_H 1 #define CONFIG_INT128 1 |