summaryrefslogtreecommitdiffstats
path: root/doc
diff options
context:
space:
mode:
authorTiziano Müller <tiziano.mueller@stepping-stone.ch>2014-07-18 09:24:38 +0200
committerVijay Bellur <vbellur@redhat.com>2014-07-19 14:14:03 -0700
commit57c61d70ec1920f731f9509510e6913aa1d62aa3 (patch)
tree21f671c9534021e95c9188ef7bbf4091b134709c /doc
parentd30c3dcf1137a0a94c0be0d0c57de86aadad2a33 (diff)
build: add libraries to LIBADD instead of LDFLAGS
For a number of linker flags the order of the object files and the libs to link against matter (for example -Wl,--as-needed). Make sure that libraries are added via the LIBADD variable instead of LDFLAGS and therefore always come after the object files. Change-Id: I59d114752a0c7664b8678a72082ba5e445497fe5 Signed-off-by: Tiziano Müller <tiziano.mueller@stepping-stone.ch> Reviewed-on: http://review.gluster.org/8331 Reviewed-by: Harshavardhana <harsha@harshavardhana.net> Reviewed-by: Prashanth Pai <ppai@redhat.com> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'doc')
-rw-r--r--doc/hacker-guide/en-US/markdown/translator-development.md6
1 files changed, 3 insertions, 3 deletions
diff --git a/doc/hacker-guide/en-US/markdown/translator-development.md b/doc/hacker-guide/en-US/markdown/translator-development.md
index 77d1b606ae0..edadd5150dc 100644
--- a/doc/hacker-guide/en-US/markdown/translator-development.md
+++ b/doc/hacker-guide/en-US/markdown/translator-development.md
@@ -347,11 +347,11 @@ CFLAGS = -fPIC -Wall -O0 -g \
-DHAVE_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE \
-D$(HOST_OS) -I$(GLFS_SRC) -I$(GLFS_SRC)/contrib/uuid \
-I$(GLFS_SRC)/libglusterfs/src
-LDFLAGS = -shared -nostartfiles -L$(GLFS_LIB) -lglusterfs \
- -lpthread
+LDFLAGS = -shared -nostartfiles -L$(GLFS_LIB)
+LIBS = -lglusterfs -lpthread
$(TARGET): $(OBJECTS)
- $(CC) $(OBJECTS) $(LDFLAGS) -o $(TARGET)
+ $(CC) $(OBJECTS) $(LDFLAGS) -o $(TARGET) $(OBJECTS) $(LIBS)
```
Yes, it's still Linux-specific. Mea culpa. As you can see, we're sticking with