diff options
author | Michael Adam <obnox@samba.org> | 2015-03-30 19:48:27 +0200 |
---|---|---|
committer | Venky Shankar <vshankar@redhat.com> | 2015-04-02 05:27:46 -0700 |
commit | 41bc3f7f023de198c695bdb7708afef3910cc761 (patch) | |
tree | 429a2b1d06462644a67787259e463c48a0c11a60 /extras/glusterfs-mode.el | |
parent | db7b8d6e5d4485fc5a6e836447dfa5d3cb85b5fd (diff) |
features/bit-rot: fix CID 1124725 - use after free
Coverity fixes:
CID 1124725
CID 1291742
The problem is that gf_tw_cleanup_timers() frees the handed
in priv->timer_wheel but it can not set the pointer to NULL,
so subsequent checks for priv->timer_wheel show it as not NULL
and allow for access after free.
The proper change might be to change gf_tw_cleanup_timers() to
take a reference to the pointer and set it to NULL after free,
but since it is under contrib/, I did not want to change that
function. Instead this patch uses the function's return code
which was not used previously. (Maybe this should even be done
in a wrapper macro or function?)
Change-Id: I31d80d3df2e4dc7503d62c7819429e1a388fdfdd
BUG: 789278
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-on: http://review.gluster.org/10056
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
Diffstat (limited to 'extras/glusterfs-mode.el')
0 files changed, 0 insertions, 0 deletions