diff options
| author | Raghavendra Talur <rtalur@redhat.com> | 2012-12-21 10:50:27 +0530 |
|---|---|---|
| committer | Anand Avati <avati@redhat.com> | 2013-01-18 17:36:46 -0800 |
| commit | ee05db0b1e8ea27eb63f62b951c71388bcf69c6e (patch) | |
| tree | c300b262b4a3feae3e9ae8887551c5abf6b46290 /extras | |
| parent | 13c1c105146288a12210dfbd2b2c4cbbd6960c06 (diff) | |
extras: Don't update RETVAL with invalid value.
Problem:
Start and restart functions update the value of RETVAL internally.
Assigning $? to RETVAL after function return was updating RETVAL with
invalid value.
Fix:
Removed assignment statement after start and restart functions return.
Stop function was always returning 0 as return value due to one extra echo
command. Removed echo line.
Change-Id: Iec1a83a83463f419dd45e12daf4e5ded80568a3a
BUG: 888442
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/4349
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
Diffstat (limited to 'extras')
| -rwxr-xr-x | extras/init.d/glusterd-Redhat.in | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/extras/init.d/glusterd-Redhat.in b/extras/init.d/glusterd-Redhat.in index 8b17eb18b8e..858f82245d3 100755 --- a/extras/init.d/glusterd-Redhat.in +++ b/extras/init.d/glusterd-Redhat.in @@ -59,8 +59,6 @@ stop() killproc $BASE fi - echo - } @@ -68,7 +66,6 @@ stop() case $1 in start) start - RETVAL=$? ;; stop) stop @@ -81,7 +78,6 @@ case $1 in restart) $0 stop $0 start - RETVAL=$? ;; *) echo $"Usage: $0 {start|stop|status|restart}." |