diff options
author | Amar Tumballi <amarts@redhat.com> | 2013-09-16 14:02:25 +0530 |
---|---|---|
committer | Vijay Bellur <vbellur@redhat.com> | 2013-09-17 03:42:19 -0700 |
commit | 52ce8fc0a8a8b87afe3e77d5aeee22baa7f216f8 (patch) | |
tree | 0d02f46c234d78c4062adb4f948a7e7844e5e438 /geo-replication/syncdaemon/syncdutils.py | |
parent | 58423e6f14c7e35af97bb8abb5f61a7e719a02ce (diff) |
geo-rep: retry in case of ENOENT errors in entry creations
Change-Id: I8961633a7371c941a3feee44c949d5c934eca998
Original-Author: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 847839
Reviewed-on: http://review.gluster.org/5933
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Tested-by: Venky Shankar <vshankar@redhat.com>
Diffstat (limited to 'geo-replication/syncdaemon/syncdutils.py')
-rw-r--r-- | geo-replication/syncdaemon/syncdutils.py | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/geo-replication/syncdaemon/syncdutils.py b/geo-replication/syncdaemon/syncdutils.py index 2655dd9835e..348eb38c1d0 100644 --- a/geo-replication/syncdaemon/syncdutils.py +++ b/geo-replication/syncdaemon/syncdutils.py @@ -35,6 +35,7 @@ except ImportError: # auxillary gfid based access prefix _CL_AUX_GFID_PFX = ".gfid/" +GF_OP_RETRIES = 20 def escape(s): """the chosen flavor of string escaping, used all over @@ -405,10 +406,11 @@ def md5hex(s): def selfkill(sig=SIGTERM): os.kill(os.getpid(), sig) -def errno_wrap(call, arg=[], errnos=[]): +def errno_wrap(call, arg=[], errnos=[], retry_errnos=[ESTALE]): """ wrapper around calls resilient to errnos. - retry in case of ESTALE + retry in case of ESTALE by default. """ + nr_tries = 0 while True: try: return call(*arg) @@ -416,9 +418,14 @@ def errno_wrap(call, arg=[], errnos=[]): ex = sys.exc_info()[1] if ex.errno in errnos: return ex.errno - if not ex.errno == ESTALE: + if not ex.errno in retry_errnos: raise - time.sleep(0.5) # retry the call + nr_tries += 1 + if nr_tries == GF_OP_RETRIES: + # probably a screwed state, cannot do much... + logging.warn('reached maximum retries (%s)...' % repr(arg)) + return + time.sleep(0.250) # retry the call def lstat(e): try: |