diff options
| author | Niels de Vos <ndevos@redhat.com> | 2015-05-18 16:26:02 +0200 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2015-05-29 05:43:17 -0700 |
| commit | 8a9328e37b8c63d60583184dc8dab12f85810682 (patch) | |
| tree | 0fa017379bf5e9dfaa2e6d8132c73cc1090a3d52 /glusterfsd | |
| parent | 5d912230a7d4f9979c10ff15da724624bd8e069d (diff) | |
build: do not #include "config.h" in each file
Instead of including config.h in each file, and have the additional
config.h included from the compiler commandline (-include option).
When a .c file tests for a certain #define, and config.h was not
included, incorrect assumtions were made. With this change, it can not
happen again.
BUG: 1222319
Change-Id: I4f9097b8740b81ecfe8b218d52ca50361f74cb64
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10808
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Diffstat (limited to 'glusterfsd')
| -rw-r--r-- | glusterfsd/src/glusterfsd-messages.h | 5 | ||||
| -rw-r--r-- | glusterfsd/src/glusterfsd-mgmt.c | 5 | ||||
| -rw-r--r-- | glusterfsd/src/glusterfsd.c | 5 | ||||
| -rw-r--r-- | glusterfsd/src/glusterfsd.h | 4 |
4 files changed, 0 insertions, 19 deletions
diff --git a/glusterfsd/src/glusterfsd-messages.h b/glusterfsd/src/glusterfsd-messages.h index ba3b7a58735..1e47380f4cc 100644 --- a/glusterfsd/src/glusterfsd-messages.h +++ b/glusterfsd/src/glusterfsd-messages.h @@ -11,11 +11,6 @@ #ifndef _GLUSTERFSD_MESSAGES_H_ #define _GLUSTERFSD_MESSAGES_H_ -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #include "glfs-message-id.h" /* NOTE: Rules for message additions diff --git a/glusterfsd/src/glusterfsd-mgmt.c b/glusterfsd/src/glusterfsd-mgmt.c index 1cff44be4d0..4a84ae56a44 100644 --- a/glusterfsd/src/glusterfsd-mgmt.c +++ b/glusterfsd/src/glusterfsd-mgmt.c @@ -13,11 +13,6 @@ #include <stdlib.h> #include <signal.h> -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif /* _CONFIG_H */ - #include "glusterfs.h" #include "stack.h" #include "dict.h" diff --git a/glusterfsd/src/glusterfsd.c b/glusterfsd/src/glusterfsd.c index 61ae4e497fc..b772caa665f 100644 --- a/glusterfsd/src/glusterfsd.c +++ b/glusterfsd/src/glusterfsd.c @@ -32,11 +32,6 @@ #include <errno.h> #include <pwd.h> -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #ifdef HAVE_MALLOC_H #include <malloc.h> #endif diff --git a/glusterfsd/src/glusterfsd.h b/glusterfsd/src/glusterfsd.h index d183b0507fa..f439cef1592 100644 --- a/glusterfsd/src/glusterfsd.h +++ b/glusterfsd/src/glusterfsd.h @@ -10,10 +10,6 @@ #ifndef __GLUSTERFSD_H__ #define __GLUSTERFSD_H__ -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif #include "rpcsvc.h" #include "glusterd1-xdr.h" |