diff options
author | Kaleb S KEITHLEY <kkeithle@redhat.com> | 2015-11-18 12:28:42 -0500 |
---|---|---|
committer | Niels de Vos <ndevos@redhat.com> | 2016-01-18 01:02:34 -0800 |
commit | 50ae3e67e4f294925fc840d3f83b77f7072af54d (patch) | |
tree | d682399e0b506b09d3106ea69c0518ea6cd8e0d8 /libglusterfs/src/common-utils.c | |
parent | f3e03c9d47b7438a6f124e01e2f459c2b72b1c29 (diff) |
all: reduce "inline" usage
There are three kinds of inline functions: plain inline, extern inline,
and static inline. All three have been removed from .c files, except
those in "contrib" which aren't our problem. Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone. Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort. This part was easy to do automatically without (as far as I can
tell) any ill effect.
In the process, several pieces of dead code were flagged by the
compiler, and were removed.
backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331
Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'libglusterfs/src/common-utils.c')
-rw-r--r-- | libglusterfs/src/common-utils.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/libglusterfs/src/common-utils.c b/libglusterfs/src/common-utils.c index ef29d9983bd..81e01bf6108 100644 --- a/libglusterfs/src/common-utils.c +++ b/libglusterfs/src/common-utils.c @@ -2490,7 +2490,7 @@ out: * nr */ -inline int32_t +int32_t gf_roundup_power_of_two (int32_t nr) { int32_t result = 1; @@ -2514,7 +2514,7 @@ out: * power of two is returned. */ -inline int32_t +int32_t gf_roundup_next_power_of_two (int32_t nr) { int32_t result = 1; @@ -3394,7 +3394,7 @@ out: return running; } -static inline int +static int dht_is_linkfile_key (dict_t *this, char *key, data_t *value, void *data) { gf_boolean_t *linkfile_key_found = NULL; @@ -3410,7 +3410,7 @@ out: } -inline gf_boolean_t +gf_boolean_t dht_is_linkfile (struct iatt *buf, dict_t *dict) { gf_boolean_t linkfile_key_found = _gf_false; |