glusterfs.git -

diff options

author	Sunny Kumar <sunkumar@redhat.com>	2018-08-13 12:18:51 +0530
committer	Amar Tumballi <amarts@redhat.com>	2018-08-31 01:29:06 +0000
commit	4996a229f3d09cbb6ed3b9dcdf1d527f36803919 (patch)
tree	0d8416d86e039858f6d9e81a1e3785a4442f622f /libglusterfs/src/common-utils.c
parent	25c405ac688787ea3f03ca4d427f2b00544dbbd0 (diff)

libglusterfs : fix coverity issues in common-utils.c

Fixes CID 1351691, 1351678, 1274192, 1274117, 1124845. Change-Id: I65805524de85fb2186260288641390458a719499 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar@redhat.com>

Diffstat (limited to 'libglusterfs/src/common-utils.c')

-rw-r--r--

libglusterfs/src/common-utils.c

1 files changed, 18 insertions, 6 deletions

/* Copyright (c) 2010-2016 Red Hat, Inc. <http://www.redhat.com> This file is part of GlusterFS. This file is licensed to you under your choice of the GNU Lesser General Public License, version 3 or any later version (LGPLv3 or later), or the GNU General Public License, version 2 (GPLv2), in all cases as published by the Free Software Foundation. */ #include <stdio.h> #include <string.h> #include <stdlib.h> #include <netinet/in.h> #include <sys/socket.h> #include <sys/types.h> #include <sys/resource.h> #include <sys/file.h> #include <netdb.h> #include <signal.h> #include <libgen.h> #include <sys/utsname.h> #include <stdint.h> #include <pthread.h> #include <sys/stat.h> #include <fcntl.h> #include <time.h> #include <semaphore.h> #include <errno.h> #ifdef HAVE_MALLOC_H #include <malloc.h> #endif #ifdef HAVE_MALLOC_STATS #ifdef DEBUG #include <mcheck.h> #endif #endif #include "cli.h" #include "cli-quotad-client.h" #include "cli-cmd.h" #include "cli-mem-types.h" #include "xlator.h" #include "glusterfs.h" #include "compat.h" #include "logging.h" #include "dict.h" #include "list.h" #include "timer.h" #include "stack.h" #include "revision.h" #include "common-utils.h" #include "event.h" #include "globals.h" #include "syscall.h" #include "call-stub.h" #include <fnmatch.h> #include "xdr-generic.h" extern int connected; /* using argp for command line parsing */ const char *argp_program_version = "" \ PACKAGE_NAME" "PACKAGE_VERSION \ "\nRepository revision: " GLUSTERFS_REPOSITORY_REVISION "\n" \ "Copyright (c) 2006-2016 Red Hat, Inc. " \ "<https://www.gluster.org/>\n" \ "GlusterFS comes with ABSOLUTELY NO WARRANTY.\n" \ "It is licensed to you under your choice of the GNU Lesser\n" \ "General Public License, version 3 or any later version (LGPLv3\n" \ "or later), or the GNU General Public License, version 2 (GPLv2),\n" \ "in all cases as published by the Free Software Foundation."; const char *argp_program_bug_address = "<" PACKAGE_BUGREPORT ">"; struct rpc_clnt *global_quotad_rpc; struct rpc_clnt *global_rpc; rpc_clnt_prog_t *cli_rpc_prog; extern struct rpc_clnt_program cli_prog; static int glusterfs_ctx_defaults_init (glusterfs_ctx_t *ctx) { cmd_args_t *cmd_args = NULL; struct rlimit lim = {0, }; call_pool_t *pool = NULL; int ret = -1; ret = xlator_mem_acct_init (THIS, cli_mt_end); if (ret != 0) { return ret; } ctx->process_uuid = generate_glusterfs_ctx_id (); if (!ctx->process_uuid) return -1; ctx->page_size = 128 * GF_UNIT_KB; ctx->iobuf_pool = iobuf_pool_new (); if (!ctx->iobuf_pool) return -1; ctx->event_pool = event_pool_new (DEFAULT_EVENT_POOL_SIZE, STARTING_EVENT_THREADS); if (!ctx->event_pool) return -1; pool = GF_CALLOC (1, sizeof (call_pool_t), cli_mt_call_pool_t); if (!pool) return -1; /* frame_mem_pool size 112 * 64 */ pool->frame_mem_pool = mem_pool_new (call_frame_t, 32); if (!pool->frame_mem_pool) return -1; /* stack_mem_pool size 256 * 128 */ pool->stack_mem_pool = mem_pool_new (call_stack_t, 16); if (!pool->stack_mem_pool) return -1; ctx->stub_mem_pool = mem_pool_new (call_stub_t, 16); if (!ctx->stub_mem_pool) return -1; ctx->dict_pool = mem_pool_new (dict_t, 32); if (!ctx->dict_pool) return -1; ctx->dict_pair_pool = mem_pool_new (data_pair_t, 512); if (!ctx->dict_pair_pool) return -1; ctx->dict_data_pool = mem_pool_new (data_t, 512); if (!ctx->dict_data_pool) return -1; ctx->logbuf_pool = mem_pool_new (log_buf_t, 256); if (!ctx->logbuf_pool) return -1; INIT_LIST_HEAD (&pool->all_frames); LOCK_INIT (&pool->lock); ctx->pool = pool; cmd_args = &ctx->cmd_args; INIT_LIST_HEAD (&cmd_args->xlator_options); lim.rlim_cur = RLIM_INFINITY; lim.rlim_max = RLIM_INFINITY; setrlimit (RLIMIT_CORE, &lim); return 0; } static int logging_init (glusterfs_ctx_t *ctx, struct cli_state *state) { char *log_file = state->log_file ? state->log_file : DEFAULT_CLI_LOG_FILE_DIRECTORY "/cli.log"; /* passing ident as NULL means to use default ident for syslog */ if (gf_log_init (ctx, log_file, NULL) == -1) { fprintf (stderr, "ERROR: failed to open logfile %s\n", log_file); return -1; } /* CLI should not have something to DEBUG after the release, hence defaulting to INFO loglevel */ gf_log_set_loglevel ((state->log_level == GF_LOG_NONE) ? GF_LOG_INFO : state->log_level); return 0; } int cli_submit_request (struct rpc_clnt *rpc, void *req, call_frame_t *frame, rpc_clnt_prog_t *prog, int procnum, struct iobref *iobref, xlator_t *this, fop_cbk_fn_t cbkfn, xdrproc_t xdrproc) { int ret = -1; int count = 0; struct iovec iov = {0, }; struct iobuf *iobuf = NULL; char new_iobref = 0; ssize_t xdr_size = 0; GF_ASSERT (this); if (req) { xdr_size = xdr_sizeof (xdrproc, req); iobuf = iobuf_get2 (this->ctx->iobuf_pool, xdr_size); if (!iobuf) { goto out; }; if (!iobref) { iobref = iobref_new (); if (!iobref) { goto out; } new_iobref = 1; } iobref_add (iobref, iobuf); iov.iov_base = iobuf->ptr; iov.iov_len = iobuf_size (iobuf); /* Create the xdr payload */ ret = xdr_serialize_generic (iov, req, xdrproc); if (ret == -1) { goto out; } iov.iov_len = ret; count = 1; } if (!rpc) rpc = global_rpc; /* Send the msg */ ret = rpc_clnt_submit (rpc, prog, procnum, cbkfn, &iov, count, NULL, 0, iobref, frame, NULL, 0, NULL, 0, NULL); ret = 0; out: if (new_iobref) iobref_unref (iobref); if (iobuf) iobuf_unref (iobuf); return ret; } int cli_rpc_notify (struct rpc_clnt *rpc, void *mydata, rpc_clnt_event_t event, void *data) { xlator_t *this = NULL; int ret = 0; this = mydata; switch (event) { case RPC_CLNT_CONNECT: { cli_cmd_broadcast_connected (); gf_log (this->name, GF_LOG_TRACE, "got RPC_CLNT_CONNECT"); break; } case RPC_CLNT_DISCONNECT: { gf_log (this->name, GF_LOG_TRACE, "got RPC_CLNT_DISCONNECT"); connected = 0; if (!global_state->prompt && global_state->await_connected) { ret = 1; cli_out ("Connection failed. Please check if gluster " "daemon is operational."); exit (ret); } break; } default: gf_log (this->name, GF_LOG_TRACE, "got some other RPC event %d", event); ret = 0; break; } return ret; } static gf_boolean_t is_valid_int (char *str) { if (*str == '-') ++str; /* Handle empty string or just "-".*/ if (!*str) return _gf_false; /* Check for non-digit chars in the rest of the string */ while (*str) { if (!isdigit(*str)) return _gf_false; else ++str; } return _gf_true; } /* * ret: 0: option successfully processed * 1: signalling end of option list * -1: unknown option * -2: parsing issue (avoid unknown option error) */ int cli_opt_parse (char *opt, struct cli_state *state) { char *oarg = NULL; gf_boolean_t secure_mgmt_tmp = 0; if (strcmp (opt, "") == 0) return 1; if (strcmp (opt, "version") == 0) { cli_out ("%s", argp_program_version); exit (0); } if (strcmp (opt, "print-logdir") == 0) { cli_out ("%s", DEFAULT_LOG_FILE_DIRECTORY); exit (0); } if (strcmp (opt, "print-statedumpdir") == 0) { cli_out ("%s", DEFAULT_VAR_RUN_DIRECTORY); exit (0); } if (strcmp (opt, "xml") == 0) { #if (HAVE_LIB_XML) state->mode |= GLUSTER_MODE_XML; #else cli_err ("XML output not supported. Ignoring '--xml' option"); #endif return 0; } if (strcmp (opt, "wignore") == 0) { state->mode |= GLUSTER_MODE_WIGNORE; return 0; } oarg = strtail (opt, "mode="); if (oarg) { if (strcmp (oarg, "script") == 0) { state->mode |= GLUSTER_MODE_SCRIPT; return 0; } if (strcmp (oarg, "interactive") == 0) return 0; return -1; } oarg = strtail (opt, "remote-host="); if (oarg) { state->remote_host = oarg; return 0; } oarg = strtail (opt, "log-file="); if (oarg) { state->log_file = oarg; return 0; } oarg = strtail (opt, "timeout="); if (oarg) { if (!is_valid_int (oarg) || atoi(oarg) <= 0) { cli_err ("timeout value should be a postive integer"); return -2; /* -2 instead of -1 to avoid unknown option error */ } cli_default_conn_timeout = atoi(oarg); return 0; } oarg = strtail (opt, "log-level="); if (oarg) { int log_level = glusterd_check_log_level(oarg); if (log_level == -1) return -1; state->log_level = (gf_loglevel_t) log_level; return 0; } oarg = strtail (opt, "glusterd-sock="); if (oarg) { state->glusterd_sock = oarg; return 0; } oarg = strtail (opt, "secure-mgmt="); if (oarg) { if (gf_string2boolean(oarg,&secure_mgmt_tmp) == 0) { if (secure_mgmt_tmp) { /* See declaration for why this is an int. */ state->ctx->secure_mgmt = 1; } } else { cli_err ("invalide secure-mgmt value (ignored)"); } return 0; } return -1; } int parse_cmdline (int argc, char *argv[], struct cli_state *state) { int ret = 0; int i = 0; int j = 0; char *opt = NULL; gf_boolean_t geo_rep_config = _gf_false; state->argc=argc-1; state->argv=&argv[1]; /* Do this first so that an option can override. */ if (sys_access (SECURE_ACCESS_FILE, F_OK) == 0) { state->ctx->secure_mgmt = 1; } if (state->argc > GEO_REP_CMD_CONFIG_INDEX && strtail (state->argv[GEO_REP_CMD_INDEX], "geo") && strtail (state->argv[GEO_REP_CMD_CONFIG_INDEX], "co")) geo_rep_config = _gf_true; for (i = 0; i < state->argc; i++) { opt = strtail (state->argv[i], "--"); if (opt && !geo_rep_config) { ret = cli_opt_parse (opt, state); if (ret == -1) { cli_out ("unrecognized option --%s", opt); return ret; } else if (ret == -2) { return ret; } for (j = i; j < state->argc - 1; j++) state->argv[j] = state->argv[j + 1]; state->argc--; /* argv shifted, next check should be at i again */ i--; if (ret == 1) { /* end of cli options */ ret = 0; break; } } } state->argv[state->argc] = NULL; return ret; } int cli_cmd_tree_init (struct cli_cmd_tree *tree) { struct cli_cmd_word *root = NULL; int ret = 0; root = &tree->root; root->tree = tree; return ret; } int cli_state_init (struct cli_state *state) { struct cli_cmd_tree *tree = NULL; int ret = 0; state->log_level = GF_LOG_NONE; tree = &state->tree; tree->state = state; ret = cli_cmd_tree_init (tree); return ret; } int cli_usage_out (const char *usage) { GF_ASSERT (usage); GF_ASSERT (usage[0] != '\0'); if (!usage || usage[0] == '\0') return -1; cli_err ("Usage: %s", usage); return 0; } int _cli_err (const char *fmt, ...) { va_list ap; int ret = 0; #ifdef HAVE_READLINE struct cli_state *state = global_state; #endif va_start (ap, fmt); #ifdef HAVE_READLINE if (state->rl_enabled && !state->rl_processing) { va_end (ap); return cli_rl_err (state, fmt, ap); } #endif ret = vfprintf (stderr, fmt, ap); fprintf (stderr, "\n"); va_end (ap); return ret; } int _cli_out (const char *fmt, ...) { va_list ap; int ret = 0; #ifdef HAVE_READLINE struct cli_state *state = global_state; #endif va_start (ap, fmt); #ifdef HAVE_READLINE if (state->rl_enabled && !state->rl_processing) { va_end (ap); return cli_rl_out (state, fmt, ap); } #endif ret = vprintf (fmt, ap); printf ("\n"); va_end (ap); return ret; } struct rpc_clnt * cli_quotad_clnt_rpc_init (void) { struct rpc_clnt *rpc = NULL; dict_t *rpc_opts = NULL; int ret = -1; rpc_opts = dict_new (); if (!rpc_opts) { ret = -1; goto out; } ret = dict_set_str (rpc_opts, "transport.address-family", "unix"); if (ret) goto out; ret = dict_set_str (rpc_opts, "transport-type", "socket"); if (ret) goto out; ret = dict_set_str (rpc_opts, "transport.socket.connect-path",


context:
space:
mode: