diff options
author | Jeff Darcy <jdarcy@fb.com> | 2017-06-29 06:50:56 -0700 |
---|---|---|
committer | Niels de Vos <ndevos@redhat.com> | 2017-06-30 10:31:02 +0000 |
commit | 0be8e038d9bf90be94f3e3a7d6ea5bee88da9ecb (patch) | |
tree | 2f23f3b205a9bdd386488cc00a3d4b1f23b4a076 /libglusterfs/src/gf-dirent.h | |
parent | 50d72373fadf1174918e754e31bae3806aa4c214 (diff) |
multiple: fix struct/typedef inconsistencies
The most common pattern, both in our code and elsewhere, is this:
struct _xyz {
...
};
typedef struct _xyz xyz_t;
These exceptions - especially call_frame/call_stack - have been slowing
down code navigation for years. By converging on a single pattern,
navigating from xyz_t in code to the actual definition of struct _xyz
(i.e. without having to visit the typedef first) might even be
automatable.
Change-Id: I0e5dd1f51f98e000173c62ef4ddc5b21d9ec44ed
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17650
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'libglusterfs/src/gf-dirent.h')
-rw-r--r-- | libglusterfs/src/gf-dirent.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/libglusterfs/src/gf-dirent.h b/libglusterfs/src/gf-dirent.h index caa09c1728e..fa323396e92 100644 --- a/libglusterfs/src/gf-dirent.h +++ b/libglusterfs/src/gf-dirent.h @@ -27,20 +27,20 @@ uint64_t gf_dirent_orig_offset (xlator_t *this, uint64_t offset); -struct _dir_entry_t { - struct _dir_entry_t *next; +struct _dir_entry { + struct _dir_entry *next; char *name; char *link; struct iatt buf; }; -struct _gf_dirent_t { +struct _gf_dirent { union { struct list_head list; struct { - struct _gf_dirent_t *next; - struct _gf_dirent_t *prev; + struct _gf_dirent *next; + struct _gf_dirent *prev; }; }; uint64_t d_ino; |