summaryrefslogtreecommitdiffstats
path: root/libglusterfs/src/gfdb/gfdb_data_store.c
diff options
context:
space:
mode:
authorJoseph Fernandes <josferna@redhat.com>2015-08-27 17:23:07 +0530
committerDan Lambright <dlambrig@redhat.com>2015-09-08 05:13:00 -0700
commit96af474045c9ba5ab74ca76daa823d91a0a0c610 (patch)
treeb9f8991807f1d5a41eee82ff69788161af815e72 /libglusterfs/src/gfdb/gfdb_data_store.c
parent9efce73fb31d520706a6d47de4daa4fb3366e6a6 (diff)
tier/ctr: Solving DB Lock issue due to write contention from db connections
Problem: The DB on the brick is been accessed by CTR, for write and tier migrator, for read and write. The write from tier migrator is reseting the heat counters after a cycle. Since we are using sqlite, two connections trying to write would cause a db lock contention. As a result CTR used to fail to update the db. Solution: Using the same db connection of CTR for reseting the heat counters. 1) Introducted a new IPC FOP for CTR 2) After the query do a ipc syncop to the underlying client xlator associated to the brick. 3) CTR in brick will catch the IPC FOP and cleat the heat counters. Change-Id: I53306bfc08dcdba479deb4ccc154896521336150 BUG: 1260730 Signed-off-by: Joseph Fernandes <josferna@redhat.com> Reviewed-on: http://review.gluster.org/12031 Tested-by: NetBSD Build System <jenkins@build.gluster.org> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Dan Lambright <dlambrig@redhat.com> Tested-by: Dan Lambright <dlambrig@redhat.com>
Diffstat (limited to 'libglusterfs/src/gfdb/gfdb_data_store.c')
-rw-r--r--libglusterfs/src/gfdb/gfdb_data_store.c35
1 files changed, 34 insertions, 1 deletions
diff --git a/libglusterfs/src/gfdb/gfdb_data_store.c b/libglusterfs/src/gfdb/gfdb_data_store.c
index e1786a6ab06..9ea9150f3c3 100644
--- a/libglusterfs/src/gfdb/gfdb_data_store.c
+++ b/libglusterfs/src/gfdb/gfdb_data_store.c
@@ -678,6 +678,40 @@ find_recently_changed_files_freq(gfdb_conn_node_t *_conn_node,
}
+
+
+/*Libgfdb API Function: Clear the heat for all the files
+ *
+ * Arguments:
+ * _conn_node : GFDB Connection node
+ *
+ * Returns : if successful return 0 or
+ * -ve value in case of failure
+ **/
+
+int
+clear_files_heat (gfdb_conn_node_t *_conn_node) {
+ int ret = 0;
+ gfdb_db_operations_t *db_operations_t = NULL;
+ void *gf_db_connection = NULL;
+
+ CHECK_CONN_NODE(_conn_node);
+
+ db_operations_t = &_conn_node->gfdb_connection.gfdb_db_operations;
+ gf_db_connection = _conn_node->gfdb_connection.gf_db_connection;
+
+ if (db_operations_t->clear_files_heat_op) {
+ ret = db_operations_t->clear_files_heat_op (gf_db_connection);
+ if (ret) {
+ gf_msg (GFDB_DATA_STORE, GF_LOG_ERROR, 0,
+ LG_MSG_FIND_OP_FAILED,
+ "Clear files heat operation failed!");
+ }
+ }
+
+ return ret;
+}
+
void get_gfdb_methods (gfdb_methods_t *methods)
{
methods->init_db = init_db;
@@ -686,5 +720,4 @@ void get_gfdb_methods (gfdb_methods_t *methods)
methods->find_recently_changed_files = find_recently_changed_files;
methods->find_unchanged_for_time_freq = find_unchanged_for_time_freq;
methods->find_recently_changed_files_freq = find_recently_changed_files_freq;
- methods->dbpath = strdup(GFDB_SQL_PARAM_DBPATH);
}