diff options
| author | Jeff Darcy <jdarcy@redhat.com> | 2015-07-28 12:11:12 -0400 |
|---|---|---|
| committer | Jeff Darcy <jdarcy@redhat.com> | 2015-09-01 04:55:15 -0700 |
| commit | 0773ca67fdb60a142207759fa6c07a69882ce59c (patch) | |
| tree | 027101fce644fe17e58c78321b1632f38aaed166 /libglusterfs/src/gfdb/gfdb_sqlite3_helper.c | |
| parent | 038dfe57cf0c5944b0392332dbf5a00bb1208150 (diff) | |
all: reduce "inline" usage
There are three kinds of inline functions: plain inline, extern inline,
and static inline. All three have been removed from .c files, except
those in "contrib" which aren't our problem. Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone. Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort. This part was easy to do automatically without (as far as I can
tell) any ill effect.
In the process, several pieces of dead code were flagged by the
compiler, and were removed.
Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155
BUG: 1245331
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/11769
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Diffstat (limited to 'libglusterfs/src/gfdb/gfdb_sqlite3_helper.c')
| -rw-r--r-- | libglusterfs/src/gfdb/gfdb_sqlite3_helper.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/libglusterfs/src/gfdb/gfdb_sqlite3_helper.c b/libglusterfs/src/gfdb/gfdb_sqlite3_helper.c index 68e0991bff2..0e27e00ed05 100644 --- a/libglusterfs/src/gfdb/gfdb_sqlite3_helper.c +++ b/libglusterfs/src/gfdb/gfdb_sqlite3_helper.c @@ -20,7 +20,7 @@ * * ****************************************************************************/ -static inline int +static int gf_sql_delete_all (gf_sql_connection_t *sql_conn, char *gfid) { @@ -118,7 +118,7 @@ out: return ret; } -static inline int +static int gf_sql_delete_link (gf_sql_connection_t *sql_conn, char *gfid, char *pargfid, @@ -201,7 +201,7 @@ out: -static inline int +static int gf_sql_update_link_flags (gf_sql_connection_t *sql_conn, char *gfid, char *pargfid, @@ -303,7 +303,7 @@ out: } -static inline int +static int gf_sql_insert_link (gf_sql_connection_t *sql_conn, char *gfid, char *pargfid, @@ -416,7 +416,7 @@ out: } -static inline int +static int gf_sql_update_link (gf_sql_connection_t *sql_conn, char *gfid, char *pargfid, @@ -537,7 +537,7 @@ out: return ret; } -static inline int +static int gf_sql_insert_write_wind_time (gf_sql_connection_t *sql_conn, char *gfid, gfdb_time_t *wind_time) @@ -618,7 +618,7 @@ out: /*Update write/read times for both wind and unwind*/ -static inline int +static int gf_update_time (gf_sql_connection_t *sql_conn, char *gfid, gfdb_time_t *update_time, |