diff options
author | Susant Palai <spalai@redhat.com> | 2018-07-26 00:51:33 +0530 |
---|---|---|
committer | Amar Tumballi <amarts@redhat.com> | 2018-08-13 14:42:32 +0000 |
commit | d3b0af8e64df14ff310044f35387c9de4d36df0a (patch) | |
tree | 2cc1bb8c295167582e5ba56a88979166625b97c1 /libglusterfs/src/gidcache.c | |
parent | 885c56b6f3c43cea0b27345f47f5522b42ebf278 (diff) |
cloudsync: fix -Werror=format-truncation error on gcc8
Here is the gcc8 warning:
libcloudsyncs3.c: In function ‘aws_download_s3’:
libcloudsyncs3.c:480:48: error: ‘%s’ directive output may be
truncated writing up to 4095 bytes into a region of size
1015 [-Werror=format-truncation=]
snprintf(buf, sizeof(buf), "https://%s/%s", priv->hostname, resource);
libcloudsyncs3.c:480:9: note: ‘snprintf’ output 10 or more bytes
(assuming 4105) into a destination of size 1024
snprintf(buf, sizeof(buf), "https://%s/%s", priv->hostname, resource);
Memleak:
It fixes a memleak as well where sign_req in fn: aws_form_request was
not freed. Adjusted the calloc size for sign_req as well to match with
the demand.
Test:
Have tested the local cloudsync regression test to validate the changes.
Smoke validation will be sufficient for the gcc8 warning fixes.
Fixes: bz#1609126
Change-Id: I1c537b30168f2e0b54862344a951843e86b0b488
Signed-off-by: Susant Palai <spalai@redhat.com>
Diffstat (limited to 'libglusterfs/src/gidcache.c')
0 files changed, 0 insertions, 0 deletions