diff options
| author | Yaniv Kaul <ykaul@redhat.com> | 2019-06-09 13:31:31 +0300 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2019-06-14 16:50:32 +0000 |
| commit | 0a6fe8551ac9807a8b6ad62241ec8048cf9f9025 (patch) | |
| tree | 7f6d6b7920ed775c75ca7b4a3dd14aceef5eec38 /libglusterfs/src/glusterfs/xlator.h | |
| parent | 65e3624091e895ca32cd91468552589f34d17595 (diff) | |
multiple files: another attempt to remove includes
There are many include statements that are not needed.
A previous more ambitious attempt failed because of *BSD plafrom
(see https://review.gluster.org/#/c/glusterfs/+/21929/ )
Now trying a more conservative reduction.
It does not solve all circular deps that we have, but it
does reduce some of them. There is just too much to handle
reasonably (dht-common.h includes dht-lock.h which includes
dht-common.h ...), but it does reduce the overall number of lines
of include we need to look at in the future to understand and fix
the mess later one.
Change-Id: I550cd001bdefb8be0fe67632f783c0ef6bee3f9f
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Diffstat (limited to 'libglusterfs/src/glusterfs/xlator.h')
| -rw-r--r-- | libglusterfs/src/glusterfs/xlator.h | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/libglusterfs/src/glusterfs/xlator.h b/libglusterfs/src/glusterfs/xlator.h index 1a0ed99774b..42cbdc1ac93 100644 --- a/libglusterfs/src/glusterfs/xlator.h +++ b/libglusterfs/src/glusterfs/xlator.h @@ -11,19 +11,16 @@ #ifndef _XLATOR_H #define _XLATOR_H -#include <stdio.h> -#include <stdint.h> -#include <inttypes.h> - +#include <stdint.h> // for int32_t +#include <sys/types.h> // for off_t, mode_t, off64_t, dev_t +#include "glusterfs-fops.h" // for GF_FOP_MAXVALUE, entrylk_cmd +#include "glusterfs/atomic.h" // for gf_atomic_t +#include "glusterfs/glusterfs.h" // for gf_boolean_t, glusterfs_ctx_t +#include "glusterfs/compat-uuid.h" // for uuid_t +#include "glusterfs/compat.h" #include "glusterfs/event-history.h" -#include "glusterfs/logging.h" -#include "glusterfs/common-utils.h" #include "glusterfs/dict.h" -#include "glusterfs/compat.h" -#include "glusterfs/list.h" #include "glusterfs/latency.h" -#include "glusterfs/compat-uuid.h" -#include "glusterfs/syscall.h" #define FIRST_CHILD(xl) (xl->children->xlator) #define SECOND_CHILD(xl) (xl->children->next->xlator) |