diff options
| author | Yaniv Kaul <ykaul@redhat.com> | 2018-08-02 16:02:33 +0300 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2018-08-14 05:15:04 +0000 |
| commit | b2b6ab8eff317f6a507ab23897ea6cd5c718d99a (patch) | |
| tree | 45fb1392f535f0236f057d9d9c932feda4f9ab40 /libglusterfs/src/inode.c | |
| parent | 32c8f70f49c0e287c53998e37867f00fa775377b (diff) | |
All: remove memset() before sprintf()
It's not needed.
There's a good chance the compiler is smart enough to remove it
anyway, but it can't hurt - I hope.
Compile-tested only!
Change-Id: Id7c054e146ba630227affa591007803f3046416b
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Diffstat (limited to 'libglusterfs/src/inode.c')
| -rw-r--r-- | libglusterfs/src/inode.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/libglusterfs/src/inode.c b/libglusterfs/src/inode.c index b8f1539b2f4..488486f35b8 100644 --- a/libglusterfs/src/inode.c +++ b/libglusterfs/src/inode.c @@ -2449,25 +2449,21 @@ inode_dump_to_dict (inode_t *inode, char *prefix, dict_t *dict) if (ret) return; - memset (key, 0, sizeof (key)); snprintf (key, sizeof (key), "%s.gfid", prefix); ret = dict_set_dynstr (dict, key, gf_strdup (uuid_utoa (inode->gfid))); if (ret) goto out; - memset (key, 0, sizeof (key)); snprintf (key, sizeof (key), "%s.nlookup", prefix); ret = dict_set_uint64 (dict, key, inode->nlookup); if (ret) goto out; - memset (key, 0, sizeof (key)); snprintf (key, sizeof (key), "%s.ref", prefix); ret = dict_set_uint32 (dict, key, inode->ref); if (ret) goto out; - memset (key, 0, sizeof (key)); snprintf (key, sizeof (key), "%s.ia_type", prefix); ret = dict_set_int32 (dict, key, inode->ia_type); @@ -2488,26 +2484,22 @@ inode_table_dump_to_dict (inode_table_t *itable, char *prefix, dict_t *dict) if (ret) return; - memset (key, 0, sizeof (key)); snprintf (key, sizeof (key), "%s.itable.active_size", prefix); ret = dict_set_uint32 (dict, key, itable->active_size); if (ret) goto out; - memset (key, 0, sizeof (key)); snprintf (key, sizeof (key), "%s.itable.lru_size", prefix); ret = dict_set_uint32 (dict, key, itable->lru_size); if (ret) goto out; - memset (key, 0, sizeof (key)); snprintf (key, sizeof (key), "%s.itable.purge_size", prefix); ret = dict_set_uint32 (dict, key, itable->purge_size); if (ret) goto out; list_for_each_entry (inode, &itable->active, list) { - memset (key, 0, sizeof (key)); snprintf (key, sizeof (key), "%s.itable.active%d", prefix, count++); inode_dump_to_dict (inode, key, dict); @@ -2515,7 +2507,6 @@ inode_table_dump_to_dict (inode_table_t *itable, char *prefix, dict_t *dict) count = 0; list_for_each_entry (inode, &itable->lru, list) { - memset (key, 0, sizeof (key)); snprintf (key, sizeof (key), "%s.itable.lru%d", prefix, count++); inode_dump_to_dict (inode, key, dict); @@ -2523,7 +2514,6 @@ inode_table_dump_to_dict (inode_table_t *itable, char *prefix, dict_t *dict) count = 0; list_for_each_entry (inode, &itable->purge, list) { - memset (key, 0, sizeof (key)); snprintf (key, sizeof (key), "%s.itable.purge%d", prefix, count++); inode_dump_to_dict (inode, key, dict); |