summaryrefslogtreecommitdiffstats
path: root/libglusterfs/src/logging.c
diff options
context:
space:
mode:
authorKotresh HR <khiremat@redhat.com>2018-11-05 11:46:41 +0530
committerAtin Mukherjee <amukherj@redhat.com>2018-11-06 02:22:35 +0000
commit3c6cf9a4a1b46cab2dc53c1ee0afca0fe993102e (patch)
tree80cc79a0e9470c500cf45629bf86cc655ee67ad2 /libglusterfs/src/logging.c
parent74e8328d3f6901d6ba38a313965fe910c8411324 (diff)
geo-rep: Fix traceback with symlink metadata sync
While syncing metadata, 'os.chmod', 'os.chown', 'os.utime' should be used without de-reference. But python supports only 'os.chown' without de-reference. That's mostly because Linux doesn't support 'chmod' on symlink file itself but it does support 'chown'. So while syncing metadata ops, if it's symlink we should only sync 'chown' and not do 'chmod' and 'utime'. It will lead to tracebacks with errors like EROFS, EPERM, ACCESS, ENOENT. All the three errors (EPERM, ACCESS, ENOENT) were handled except EROFS. But the way it was handled was not fool proof. The operation is tried and failure was handled based on the errors. All the errors with symlink file for 'chown', 'utime' had to be passed to safe errors list of 'errno_wrap'. This patch handles it better by avoiding 'chmod' and 'utime' if it's symlink file. fixes: bz#1646104 Change-Id: Ic354206455cdc7ab2a87d741d81f4efe1f19d77d Signed-off-by: Kotresh HR <khiremat@redhat.com>
Diffstat (limited to 'libglusterfs/src/logging.c')
0 files changed, 0 insertions, 0 deletions