diff options
author | Raghavendra G <rgowdapp@redhat.com> | 2018-06-27 14:51:37 +0530 |
---|---|---|
committer | Raghavendra G <rgowdapp@redhat.com> | 2018-07-28 15:42:34 +0000 |
commit | 4d3c62e71f3250f10aa0344085a5ec2d45458d5c (patch) | |
tree | bd5dda8ae916cfca4936520495276c355041d211 /libglusterfs/src/run.h | |
parent | 379d4279601f694465cc7eaffcb737410d5d9e31 (diff) |
performance/write-behind: better invalidation in readdirp
Current invalidation of stats in wb_readdirp_cbk is prone to races. As
the deleted comment explains,
<snip>
We cannot guarantee integrity of entry->d_stat as there are cached
writes. The stat is most likely stale as it doesn't account the cached
writes. However, checking for non-empty liability list here is not a
fool-proof solution as there can be races like,
1. readdirp is successful on posix
2. sync of cached write is successful on posix
3. write-behind received sync response and removed the request from
liability queue
4. readdirp response is processed at write-behind.
In the above scenario, stat for the file is sent back in readdirp
response but it is stale.
</snip>
Change-Id: I6ce170985cc6ce3df2382ec038dd5415beefded5
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Updates: bz#1512691
Diffstat (limited to 'libglusterfs/src/run.h')
0 files changed, 0 insertions, 0 deletions