summaryrefslogtreecommitdiffstats
path: root/libglusterfs/src
diff options
context:
space:
mode:
authorSanju Rakonde <srakonde@redhat.com>2017-09-25 17:29:25 +0530
committerNiels de Vos <ndevos@redhat.com>2017-09-29 07:46:53 +0000
commit2c124b5256bac5830d81552bfb4412620aa6cfb0 (patch)
tree5eb876a52a0efb0021c2f58bfc32dab26af209a8 /libglusterfs/src
parente4784f26bf9739853379ec13d0f921ddfb954475 (diff)
stack.h:PW.INCLUDE_RECURSION
The headerfile globals.h is recursively adding itself. ( globals.h -> xlator.h -> stack.h -> globals.h). We are finding the source files which are including the header file globals.h and removing the inclusion line. I used git grep -l stack.h | xargs git grep globals.h -- to find out the files and removed the header file from all files except libglusterfs/src/xlator.h and libglusterfs/src/Makefile.am When I try to remove header file from libglusterfs/src/xlator.h I'm getting some errors. In libglusterfs/src/Makefile.am it is required for building RPMs. Change-Id: I537218c09ade6d7ea51717768b26563a247daf60 BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
Diffstat (limited to 'libglusterfs/src')
-rw-r--r--libglusterfs/src/common-utils.c1
-rw-r--r--libglusterfs/src/stack.h1
2 files changed, 0 insertions, 2 deletions
diff --git a/libglusterfs/src/common-utils.c b/libglusterfs/src/common-utils.c
index 327c1fa13db..c90856cca33 100644
--- a/libglusterfs/src/common-utils.c
+++ b/libglusterfs/src/common-utils.c
@@ -46,7 +46,6 @@
#include "revision.h"
#include "glusterfs.h"
#include "stack.h"
-#include "globals.h"
#include "lkowner.h"
#include "syscall.h"
#include "cli1-xdr.h"
diff --git a/libglusterfs/src/stack.h b/libglusterfs/src/stack.h
index 249b6d2c54f..ddad46c9673 100644
--- a/libglusterfs/src/stack.h
+++ b/libglusterfs/src/stack.h
@@ -29,7 +29,6 @@ typedef struct call_pool call_pool_t;
#include "dict.h"
#include "list.h"
#include "common-utils.h"
-#include "globals.h"
#include "lkowner.h"
#include "client_t.h"
#include "libglusterfs-messages.h"