diff options
author | Poornima G <pgurusid@redhat.com> | 2016-06-05 00:06:11 -0400 |
---|---|---|
committer | Raghavendra G <rgowdapp@redhat.com> | 2016-06-10 04:03:40 -0700 |
commit | 3bc419d8014877f64e57dc3368b0609396ec0d12 (patch) | |
tree | 54b658168400585a1e6d9848c6355d462603a9c2 /libglusterfs/src | |
parent | a837357c5c7873bf19155e76bf6c251fa799a605 (diff) |
protocol: Add framework to send transaction id with recall
Issue:
The upcall(cache invalidation/recall) event is sent from the bricks
to clients. In AFR/EC setup, it can so happen that all the bricks
will send the upcall for the same event, and if AFR/EC doesn't filter
out these duplicate notifications, the logic above cluster xlators
can fail.
Solution:
Use transaction id to filter out duplicate notifications.
This patch adds framework for duplicate notifications.
AFR/EC can build up on this patch for deduping the notifications
Change-Id: I66b08e63b8799bc5932f2b2545376138a5701168
BUG: 1319992
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14647
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Diffstat (limited to 'libglusterfs/src')
-rw-r--r-- | libglusterfs/src/upcall-utils.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/libglusterfs/src/upcall-utils.h b/libglusterfs/src/upcall-utils.h index 33db4b273a1..f4b15e3507c 100644 --- a/libglusterfs/src/upcall-utils.h +++ b/libglusterfs/src/upcall-utils.h @@ -78,8 +78,10 @@ struct gf_upcall_cache_invalidation { }; struct gf_upcall_recall_lease { - uint32_t lease_type; - /* TODO: Add the lease type it can be downgraded to */ + uint32_t lease_type; /* Lease type to which client can downgrade to*/ + uuid_t tid; /* transaction id of the fop that caused + the recall */ + dict_t *dict; }; #endif /* _UPCALL_UTILS_H */ |