diff options
| author | Poornima G <pgurusid@redhat.com> | 2016-06-05 00:06:11 -0400 |
|---|---|---|
| committer | Raghavendra G <rgowdapp@redhat.com> | 2016-06-10 04:03:54 -0700 |
| commit | 57372682b174c1483c41e8bc2474dcfebf0b86df (patch) | |
| tree | 8cb8e92e0f8767f4894bcce21c5c95a99038a8dc /libglusterfs | |
| parent | 9c6f0d0ad7a1212f451f3cc502da3329c3534c31 (diff) | |
protocol: Add framework to send transaction id with recall
Backport of: http://review.gluster.org/#/c/14647/
Issue:
The upcall(cache invalidation/recall) event is sent from the bricks
to clients. In AFR/EC setup, it can so happen that all the bricks
will send the upcall for the same event, and if AFR/EC doesn't filter
out these duplicate notifications, the logic above cluster xlators
can fail.
Solution:
Use transaction id to filter out duplicate notifications.
This patch adds framework for duplicate notifications.
AFR/EC can build up on this patch for deduping the notifications
Change-Id: I66b08e63b8799bc5932f2b2545376138a5701168
BUG: 1337638
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/14648
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Diffstat (limited to 'libglusterfs')
| -rw-r--r-- | libglusterfs/src/upcall-utils.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/libglusterfs/src/upcall-utils.h b/libglusterfs/src/upcall-utils.h index 7acfff15a0b..78db806503f 100644 --- a/libglusterfs/src/upcall-utils.h +++ b/libglusterfs/src/upcall-utils.h @@ -37,8 +37,10 @@ struct gf_upcall_cache_invalidation { }; struct gf_upcall_recall_lease { - uint32_t lease_type; - /* TODO: Add the lease type it can be downgraded to */ + uint32_t lease_type; /* Lease type to which client can downgrade to*/ + uuid_t tid; /* transaction id of the fop that caused + the recall */ + dict_t *dict; }; #endif /* _UPCALL_UTILS_H */ |