diff options
author | Ravishankar N <ravishankar@redhat.com> | 2014-06-04 19:53:50 +0530 |
---|---|---|
committer | Niels de Vos <ndevos@redhat.com> | 2014-06-08 07:58:10 -0700 |
commit | 325c77ff9d197634656d2ed4af02fbe4de52fbcb (patch) | |
tree | b1c5714830647f8a4e949260a64a384b86f1919f /libglusterfs | |
parent | 4977a4d74f14d84f9e622a650f1ea9b47d795962 (diff) |
features/gfid-access: calloc gfid and set in xdata
Backport of http://review.gluster.org/#/c/7978/
Problem: the gfid passed to ga_fill_tmp_loc() was a stack variable which
the function set in the xdata dictionary. Accessing it in a later point
in time gave unexpected values.
This was easy to hit when AFR was involved like so:
ga_mknod()--->xxx-->afr_mknod():
In afr_mknod transaction, once the stack-winds for the lock-phase are sent,
the gfid in xdata becomes out of scope. When we send the actual op i.e.
afr_mknod_wind(), the gfid in xdata is stale, causing posix to set junk
gfids on the files.
Fix:
calloc the gfid and set it in the dict.
Thanks to Pranith for the RCA!
Change-Id: Ief2080836dc2923dec4be44dda4f6211430e535e
BUG: 1104959
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/7985
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'libglusterfs')
0 files changed, 0 insertions, 0 deletions