summaryrefslogtreecommitdiffstats
path: root/libglusterfs
diff options
context:
space:
mode:
authorRaghavendra G <rgowdapp@redhat.com>2018-08-20 16:38:41 +0530
committerRaghavendra G <rgowdapp@redhat.com>2018-08-21 11:36:51 +0000
commit0eac8026f880bf8bf7e05530de16a06ba3e8a40c (patch)
treeb338c4cd797c6bf7cea21e5a1e2b9633fc3808fa /libglusterfs
parentcb210f83455e2f659e734dfa09ff7602b5b75201 (diff)
Revert "performance/write-behind: better invalidation in readdirp"
This reverts commit 4d3c62e71f3250f10aa0344085a5ec2d45458d5c. Traversing all children of a directory in wb_readdirp caused significant performance regression. Hence reverting this patch Change-Id: I6c3b6cee2dd2aca41d49fe55ecdc6262e7cc5f34 updates: bz#1512691 Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Diffstat (limited to 'libglusterfs')
-rw-r--r--libglusterfs/src/inode.c7
-rw-r--r--libglusterfs/src/inode.h2
2 files changed, 1 insertions, 8 deletions
diff --git a/libglusterfs/src/inode.c b/libglusterfs/src/inode.c
index 488486f35b8..11814d52d7c 100644
--- a/libglusterfs/src/inode.c
+++ b/libglusterfs/src/inode.c
@@ -132,7 +132,6 @@ __dentry_unset (dentry_t *dentry)
__dentry_unhash (dentry);
list_del_init (&dentry->inode_list);
- list_del_init (&dentry->parent_list);
GF_FREE (dentry->name);
dentry->name = NULL;
@@ -142,7 +141,6 @@ __dentry_unset (dentry_t *dentry)
dentry->parent = NULL;
}
- dentry->inode = NULL;
mem_put (dentry);
}
@@ -606,7 +604,6 @@ __dentry_create (inode_t *inode, inode_t *parent, const char *name)
INIT_LIST_HEAD (&newd->inode_list);
INIT_LIST_HEAD (&newd->hash);
- INIT_LIST_HEAD (&newd->parent_list);
newd->name = gf_strdup (name);
if (newd->name == NULL) {
@@ -619,9 +616,8 @@ __dentry_create (inode_t *inode, inode_t *parent, const char *name)
newd->parent = __inode_ref (parent);
list_add (&newd->inode_list, &inode->dentry_list);
- list_add (&newd->parent_list, &parent->children);
-
newd->inode = inode;
+
out:
return newd;
}
@@ -652,7 +648,6 @@ __inode_create (inode_table_t *table)
INIT_LIST_HEAD (&newi->list);
INIT_LIST_HEAD (&newi->hash);
INIT_LIST_HEAD (&newi->dentry_list);
- INIT_LIST_HEAD (&newi->children);
newi->_ctx = GF_CALLOC (1,
(sizeof (struct _inode_ctx) * table->ctxcount),
diff --git a/libglusterfs/src/inode.h b/libglusterfs/src/inode.h
index 96f67c05629..658477700c0 100644
--- a/libglusterfs/src/inode.h
+++ b/libglusterfs/src/inode.h
@@ -60,7 +60,6 @@ struct _inode_table {
struct _dentry {
struct list_head inode_list; /* list of dentries of inode */
struct list_head hash; /* hash table pointers */
- struct list_head parent_list; /* list of parent's children */
inode_t *inode; /* inode of this directory entry */
char *name; /* name of the directory entry */
inode_t *parent; /* directory of the entry */
@@ -100,7 +99,6 @@ struct _inode {
struct list_head dentry_list; /* list of directory entries for this inode */
struct list_head hash; /* hash table pointers */
struct list_head list; /* active/lru/purge */
- struct list_head children; /* list of children */
struct _inode_ctx *_ctx; /* replacement for dict_t *(inode->ctx) */
};