diff options
author | kinsu <vpolakis@gmail.com> | 2019-09-19 08:34:32 +0000 |
---|---|---|
committer | Xavi Hernandez <xhernandez@redhat.com> | 2020-02-24 18:31:04 +0000 |
commit | 3ba0885b5be42efec01ebd42cc5fbd33dc1b2756 (patch) | |
tree | bfb59bcbbea7c7221c37853d7be59967949408ec /libglusterfs | |
parent | a0e08901a87700f967c26f146f54e2301f5d0594 (diff) |
Segmentation fault occurs during truncate
Problem:
Segmentation fault occurs when bricks are nearly full 100% and in
parallel truncate of a file is attempted (No space left on device).
Prerequicite is that performance xlators are activated
(read-ahead, write-behind etc)
while stack unwind of the frames following an error responce
from brick (No space left on device) frame->local includes a memory
location that is not allocated via mem_get but via calloc.
The destroyed frame is always ra_truncate_cbk winded from ra_ftruncate
and the inode ptr is copied to the frame local in the wb_ftruncate.
Fix:
extra check is added for the pool ptr
Change-Id: Ic5d3bd0ab7011e40b2811c6dece063b256e4d9d1
Fixes: bz#1797882
Signed-off-by: kinsu <vpolakis@gmail.com>
Diffstat (limited to 'libglusterfs')
-rw-r--r-- | libglusterfs/src/mem-pool.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/libglusterfs/src/mem-pool.c b/libglusterfs/src/mem-pool.c index ea37ffa5015..1c31c27d95b 100644 --- a/libglusterfs/src/mem-pool.c +++ b/libglusterfs/src/mem-pool.c @@ -866,6 +866,14 @@ mem_put(void *ptr) /* Not one of ours; don't touch it. */ return; } + + if (!hdr->pool_list) { + gf_msg_callingfn("mem-pool", GF_LOG_CRITICAL, EINVAL, + LG_MSG_INVALID_ARG, + "invalid argument hdr->pool_list NULL"); + return; + } + pool_list = hdr->pool_list; pt_pool = &pool_list->pools[hdr->power_of_two - POOL_SMALLEST]; |