diff options
| author | Amar Tumballi <amarts@redhat.com> | 2012-06-05 14:15:54 +0530 |
|---|---|---|
| committer | Anand Avati <avati@redhat.com> | 2012-06-05 10:45:10 -0700 |
| commit | 6eee473eba94697953e8b3e1b04fe5ef1de5f474 (patch) | |
| tree | d435b4f4186690907c39a28257f3707ea86bbeb1 /rpc/rpc-lib/src/rpc-transport.c | |
| parent | 04fd2972fe8a9b9568ac781ba7677f13fdce0f57 (diff) | |
core: coverity fixes (mostly resource leak fixes)
currently working on obvious resource leak reports in coverity
Change-Id: I261f4c578987b16da399ab5a504ad0fda0b176b1
Signed-off-by: Amar Tumballi <amarts@redhat.com>
BUG: 789278
Reviewed-on: http://review.gluster.com/3265
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Diffstat (limited to 'rpc/rpc-lib/src/rpc-transport.c')
| -rw-r--r-- | rpc/rpc-lib/src/rpc-transport.c | 20 |
1 files changed, 16 insertions, 4 deletions
diff --git a/rpc/rpc-lib/src/rpc-transport.c b/rpc/rpc-lib/src/rpc-transport.c index 8da898b61c3..d0e7834e8d7 100644 --- a/rpc/rpc-lib/src/rpc-transport.c +++ b/rpc/rpc-lib/src/rpc-transport.c @@ -257,6 +257,8 @@ rpc_transport_load (glusterfs_ctx_t *ctx, dict_t *options, char *trans_name) goto fail; } + trans->dl_handle = handle; + trans->ops = dlsym (handle, "tops"); if (trans->ops == NULL) { gf_log ("rpc-transport", GF_LOG_ERROR, @@ -319,9 +321,11 @@ rpc_transport_load (glusterfs_ctx_t *ctx, dict_t *options, char *trans_name) return_trans = trans; - if (name) { + if (name) GF_FREE (name); - } + + if (vol_opt) + GF_FREE (vol_opt); return return_trans; @@ -331,12 +335,17 @@ fail: GF_FREE (trans->name); } + if (trans->dl_handle) + dlclose (trans->dl_handle); + GF_FREE (trans); } - if (name) { + if (name) GF_FREE (name); - } + + if (vol_opt) + GF_FREE (vol_opt); return NULL; } @@ -426,6 +435,9 @@ rpc_transport_destroy (rpc_transport_t *this) if (this->name) GF_FREE (this->name); + if (this->dl_handle) + dlclose (this->dl_handle); + GF_FREE (this); fail: return ret; |