socket: throttle only connected transport

BUG: 1224016
Change-Id: I2352c6661ae5aee8cf06e572ec0462b76901d46f
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/10887
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: Raghavendra G <rgowdapp@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>

1 files changed, 15 insertions, 2 deletions

diff --git a/rpc/rpc-transport/socket/src/socket.c b/rpc/rpc-transport/socket/src/socket.c
index ece2bc8379a..e6ef7d2c220 100644
--- a/rpc/rpc-transport/socket/src/socket.c
+++ b/rpc/rpc-transport/socket/src/socket.c
@@ -3567,8 +3567,21 @@ socket_throttle (rpc_transport_t *this, gf_boolean_t onoff)
            will never read() any more data until throttling
            is turned off.
         */
-        priv->idx = event_select_on (this->ctx->event_pool, priv->sock,
-                                     priv->idx, (int) !onoff, -1);
+        pthread_mutex_lock (&priv->lock);
+        {
+
+                /* Throttling is useless on a disconnected transport. In fact,
+                 * it's dangerous since priv->idx and priv->sock are set to -1
+                 * on a disconnected transport, which breaks epoll's event to
+                 * registered fd mapping. */
+
+                if (priv->connected == 1)
+                        priv->idx = event_select_on (this->ctx->event_pool,
+                                                     priv->sock,
+                                                     priv->idx, (int) !onoff,
+                                                     -1);
+        }
+        pthread_mutex_unlock (&priv->lock);
         return 0;
 }