diff options
author | Krishnan Parthasarathi <kparthas@redhat.com> | 2013-05-14 09:59:45 +0530 |
---|---|---|
committer | Vijay Bellur <vbellur@redhat.com> | 2013-06-18 22:10:39 -0700 |
commit | bb5ded9bee8cf7671bcb7c06e9ebca91f7bf8d67 (patch) | |
tree | fdf3e85a8a786ea5208302bd06c04318b06622f3 /rpc/xdr/src/cli1-xdr.h | |
parent | bda60de187aadc885bbc705ccb9317f680f4b9d3 (diff) |
glusterd: Disable transport before cleaning up rpc object
Problem:
rpc_transport object, which is part of rpc_clnt, is destroyed
prematurely. This is because, rpc_transport object is ref'd by socket
layer and rpc layer. These ref's, until the synctask'izing of
operations, were unref'd sequentially in the epoll thread.
With more threads at play, the sequential unref guarantee is off.
Fix:
Shutting down the transport before proceeding with cleaning up of
rpc_clnt object would serialize the unref's on the rpc_transport object
and thus eliminating the race.
Also, we don't store the address of brickinfo in brick's rpc notify
function, to avoid the possibility of referring a freed brickinfo.
Instead we use a string based id to 'reach' the corresponding brickinfo.
Change-Id: If2739e2eeaee1e8b071ab2b6754b7ea0f81cfceb
BUG: 962619
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/5000
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'rpc/xdr/src/cli1-xdr.h')
0 files changed, 0 insertions, 0 deletions