afr: remove stale index entries

Problem:
During pre-op phase, the index xlator
1. Creates the entry inside .glusterfs/indices/xattrop
2. Winds the xattrop fop to posix to mark dirty/pending changelogs.
If the brick crashes after 1, the xattrop entry becomes stale and never
gets removed by shd during subsequent crawls because there is nothing to
heal (changelogs are zero).

Though the stale entry does not get displayed in the output of 'heal
info' command, it nevertheless stays there forever unless a new write
transaction is performed on the file.

Fix:
During index self-heal if afr xattrs are found to be clean (indicated by
ret value of 2 on a call to afr_shd_selfheal(), send a dummy
post-op with all 0s for the xattr values, which makes the index xlator
to unlink the stale entry.

Change-Id: I02cb2bc937f2e3f3f3cb35d67b006664dc7ef919
BUG: 1190069
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9714
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anuradha Talur <atalur@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>

1 files changed, 5 insertions, 6 deletions

diff --git a/tests/afr.rc b/tests/afr.rc
index 721f24545d5..2aae292314a 100644
--- a/tests/afr.rc
+++ b/tests/afr.rc
@@ -73,11 +73,10 @@ function is_file_heal_done {
 
 function count_sh_entries()
 {
-    val1=0
-    for g in $(ls $1/.glusterfs/indices/xattrop)
-    do
-        val1=$(( val1 + 1 ))
-    done
+    ls $1/.glusterfs/indices/xattrop | grep -v "xattrop-" | wc -l
+}
 
-    echo $val1;
+function count_index_entries()
+{
+    ls $1/.glusterfs/indices/xattrop | wc -l
 }