diff options
author | Raghavendra Talur <rtalur@redhat.com> | 2017-07-10 20:43:39 +0530 |
---|---|---|
committer | Niels de Vos <ndevos@redhat.com> | 2017-07-18 11:22:21 +0000 |
commit | 43d55c5afb1a9f731d806f7893923ac999b9ef6c (patch) | |
tree | e053b109005b8dafbb883902ba008890846e959d /tests/basic | |
parent | d26f0bac149d495fa93710c3f7b6b63c36cb8387 (diff) |
rfc.sh: make alignment check compulsory
Earlier, it was not reported if a function call had arguments on next
line and the args were not aligned to opening bracket. With this change,
it is a check that is displayed in output.
I have not analyzed what all --strict brings in. If it is found to be
more restrictive than required, we may choose to promote this *one* CHK
to WARN and stop using --strict.
Sample:
CHECK: Alignment should match open parenthesis
+ ret = gf_asprintf (&footer,
+ " [%s]", strerror(errnum));
total: 0 warnings, 1 checks, 8 lines checked
Change-Id: I48834087efcae872b69746ba962b0bb1c130b5cd
BUG: 1469179
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: https://review.gluster.org/17737
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: ankitraj
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Sonal Arora <sarora@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'tests/basic')
0 files changed, 0 insertions, 0 deletions