diff options
| author | Poornima G <pgurusid@redhat.com> | 2018-11-21 12:09:39 +0530 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2018-12-18 09:35:24 +0000 |
| commit | b87c397091bac6a4a6dec4e45a7671fad4a11770 (patch) | |
| tree | 6f7eeff5be2ae69af0eba03add10103091639a6c /tests/bugs/core | |
| parent | d50f22e6ae410fdcde573b6015b97dc1573bbb7e (diff) | |
iobuf: Get rid of pre allocated iobuf_pool and use per thread mem pool
The current implementation of iobuf_pool has two problems:
- prealloc of 12.5MB memory, this limits the scale factor of the gluster
processes due to RAM requirements
- lock contention, as the current implementation has one global
iobuf_pool lock. Credits for debugging and addressing the same goes to
Krutika Dhananjay <kdhananj@redhat.com>. Issue: #410
Hence changing the iobuf implementation to use per thread mem pool.
This may theoritically appear to cause perf dip as there is no preallocation.
But per thread mem pool will not have significant perf impact as the last
allocated memory is kept alive for subsequent allocs, for some time.
The worst case would be if iobufs requested are of random sizes each time.
The best case is, if we get iobuf request of the same size. From the perf
tests, this patch did not seem to cause any perf decrease.
Note that, with this patch, the rdma performance is going to degrade
drastically. In one of the previous patchsets we had fixes to not
degrade rdma perf, but rdma is not supported and also not tested [1].
Hence the decision was to not have code in rdma that is not tested
and not supported.
[1] https://lists.gluster.org/pipermail/gluster-users.old/2018-July/034400.html
Updates: #325
Change-Id: Ic2ef3bd498f9250dea25f25ba0c01fde19584b27
Signed-off-by: Poornima G <pgurusid@redhat.com>
Diffstat (limited to 'tests/bugs/core')
| -rw-r--r-- | tests/bugs/core/bug-1432542-mpx-restart-crash.t | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tests/bugs/core/bug-1432542-mpx-restart-crash.t b/tests/bugs/core/bug-1432542-mpx-restart-crash.t index f21bcff6a71..2cc5109f0c0 100644 --- a/tests/bugs/core/bug-1432542-mpx-restart-crash.t +++ b/tests/bugs/core/bug-1432542-mpx-restart-crash.t @@ -6,6 +6,8 @@ SCRIPT_TIMEOUT=800 . $(dirname $0)/../../volume.rc . $(dirname $0)/../../traps.rc +cleanup; + NUM_VOLS=20 MOUNT_BASE=$(dirname $M0) |